Add Revolut fiat payment provider

[claudinethelobster]

Summary

Implements Revolut fiat payment provider following the moonpay.ts pattern.

Changes

• Created src/partners/revolut.ts - Partner plugin for Revolut API integration
• Created src/routes/v1/revolut.ts - REST endpoint for Revolut transactions
• Updated src/indexApi.ts - Registered revolut router
• Updated src/demo/partners.ts - Added revolut entry (type: fiat, color: #191C33)
• Updated src/queryEngine.ts - Registered revolut plugin

Implementation Details

• Follows moonpay.ts architecture
• Uses cleaners for all external data
• Types derived from cleaners
• No unused code
• Debug logging guarded

Testing

• Implementation follows edge-reports-server conventions
• Pattern verified against moonpay.ts reference

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1213346013113653

[samholmes]

The fixup commit should have been squashed. If the fixup was apart of review feedback then it should be prefixed with fixup!.

[claudinethelobster]

Done — the fixup was squashed into the original commit (now 515be6a). The PR shows a single commit.

[samholmes]

See inline comments for specific issues.

[samholmes]

Issue: The inner pagination loop only exits when cursor == null. If the API returns a repeated, empty-string, or non-advancing cursor, this loop runs indefinitely until the outer promiseTimeout kills it—delaying progress and producing noisy retries.

Recommendation: Add a max-pages guard and track the previous cursor to break on non-advancing values:

const MAX_PAGES = 1000
let cursor: string | undefined
let pages = 0

while (true) {
  // ... existing fetch logic ...

  const prevCursor = cursor
  cursor = result.next_cursor

  // ... existing tx processing ...

  pages++
  if (cursor == null || cursor === prevCursor || pages >= MAX_PAGES) {
    break
  }
}

[samholmes]

Suggestion: This mapping logic is high-impact for reporting accuracy and currently untested. Consider adding focused unit tests covering buy/sell direction, deposit/payout currency assignment, txid placement, and payment-method conversion.

Recommendation: Add a test file such as test/partners/revolut.test.ts:

import { expect } from 'chai'
import { processRevolutTx, getRevolutPaymentType } from '../../src/partners/revolut'

describe('processRevolutTx', () => {
  const baseTx = {
    id: 'order-1',
    type: 'buy',
    state: 'completed',
    created_at: '2024-06-01T12:00:00.000Z',
    fiat_amount: 100,
    fiat_currency: 'usd',
    crypto_amount: 0.005,
    crypto_currency: 'btc',
    wallet_address: 'bc1abc',
    tx_hash: '0xabc',
    country_code: 'US',
    payment_method: 'card'
  }

  it('should map a buy tx with fiat deposit and crypto payout', () => {
    const result = processRevolutTx(baseTx)
    expect(result.direction).to.equal('buy')
    expect(result.depositCurrency).to.equal('USD')
    expect(result.payoutCurrency).to.equal('BTC')
    expect(result.payoutTxid).to.equal('0xabc')
    expect(result.depositTxid).to.be.undefined
  })

  it('should map a sell tx with crypto deposit and fiat payout', () => {
    const result = processRevolutTx({ ...baseTx, type: 'sell' })
    expect(result.direction).to.equal('sell')
    expect(result.depositCurrency).to.equal('BTC')
    expect(result.payoutCurrency).to.equal('USD')
    expect(result.depositTxid).to.equal('0xabc')
    expect(result.payoutTxid).to.be.undefined
  })
})