Jared/cursor agent/long press warning by JP0P · Pull Request #5950 · EdgeApp/edge-react-gui

JP0P · 2026-02-18T19:49:02Z

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

Yes
No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

Tested on iOS device
Tested on Android device
Tested on small-screen device (iPod Touch)
Tested on large-screen device (tablet)

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1211843114452190

samholmes

Review Summary

2 Critical Issues:

Android shortcuts won't open https URLs in browser (inconsistent with iOS implementation)
Unescaped & in Android strings.xml

4 Warnings: Inconsistent copy between platforms, double emoji on Android, different shortcut order, misleading "data loss" wording in changelog

5 Suggestions: UIApplicationShortcutItemType convention, Android icons, completion handler, code comments, localization support

See inline comments for details.

samholmes · 2026-02-20T20:13:45Z

android/app/src/main/res/xml/shortcuts.xml

+    android:shortcutLongLabel="@string/shortcut_contact_support_long">
+    <intent
+      android:action="android.intent.action.VIEW"
+      android:data="https://support.edge.app/hc/en-us?chat=open" />


Critical: Android shortcuts will not work — https URLs are not opened in the browser.

The iOS implementation in AppDelegate.swift intercepts https/http URLs and opens them directly in Safari:

if url.scheme == "https" || url.scheme == "http" { UIApplication.shared.open(url) return true }

However, Android has no equivalent native handling. The intent sends the URL to MainActivity, which passes it through React Native's Linking → parseDeepLink → launchDeepLink. The 'other' case tries to parse it as a wallet URI, fails, and shows "No wallet for this URI" toast.

Recommended fix (consistent with iOS): Add native Android handling in MainActivity to open https/http shortcut URLs in the browser before they reach React Native. This matches the iOS pattern where https URLs bypass parseDeepLink.

Alternative design consideration: If the preference is to have parseDeepLink be the central handler for all intent URIs, the fix would instead be:

Update the 'other' case in DeepLinkingActions.tsx to open unrecognized https URLs in the browser as a fallback (similar to linkReferralWithCurrencies which already does if (parsed.type === 'other') await Linking.openURL(uri))

Update iOS AppDelegate.swift to pass https URLs through RCTLinkingManager instead of opening them directly

This would centralize URL handling logic in one place (the deep link infrastructure) rather than having platform-specific native handling.

samholmes · 2026-02-20T20:13:50Z

android/app/src/main/res/values/strings.xml

+    <string name="shortcut_contact_support_short">Contact Support</string>
+    <string name="shortcut_contact_support_long">Contact support for help from a live agent</string>
+    <string name="shortcut_do_not_uninstall_short">⚠️ Save 2FA First!</string>
+    <string name="shortcut_do_not_uninstall_long">⚠️ Login requires 2FA & credentials!</string>


Critical: Unescaped ampersand in XML.

In XML, & must be escaped as &. An unescaped & can cause parse errors or unexpected behavior.

Fix:

<string name="shortcut_do_not_uninstall_long">⚠️ Login requires 2FA & credentials!</string>

samholmes · 2026-02-20T20:13:57Z

android/app/src/main/res/values/strings.xml

 <resources>
    <string name="app_name">Edge</string>
+    <string name="shortcut_contact_support_short">Contact Support</string>
+    <string name="shortcut_contact_support_long">Contact support for help from a live agent</string>


Warning: Inconsistent copy between platforms.

Platform Contact Support (long)

Android "Contact support for help from a live agent"

iOS "Get help from our live support agents"

Same feature with different wording can be confusing for localization and UX.

Recommendation: Pick one and use it on both platforms.

samholmes · 2026-02-20T20:14:04Z

android/app/src/main/res/values/strings.xml

+    <string name="shortcut_do_not_uninstall_short">⚠️ Save 2FA First!</string>
+    <string name="shortcut_do_not_uninstall_long">⚠️ Login requires 2FA & credentials!</string>


Warning: Double emoji on Android vs single on iOS.

Android short: "⚠️ Save 2FA First!"

Android long: "⚠️ Login requires 2FA & credentials!"

iOS title: "⚠️ Save 2FA First!"

iOS subtitle: "Login requires 2FA & credentials!" (no emoji)

Android uses ⚠️ in both labels; iOS only in the title. The double emoji on Android can feel redundant.

Recommendation: Remove ⚠️ from the Android long label to match iOS.

samholmes · 2026-02-20T20:14:10Z

android/app/src/main/res/xml/shortcuts.xml

@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="utf-8"?>
+<shortcuts xmlns:android="http://schemas.android.com/apk/res/android">
+  <shortcut


Warning: Shortcut order differs between platforms.

iOS: 2FA warning first, Contact Support second

Android: Contact Support first, 2FA warning second

If the order is intentional for platform UX, add a comment explaining the rationale. Otherwise, align for consistency.

samholmes · 2026-02-20T20:14:24Z

ios/edge/Info.plist

+			<string>Login requires 2FA & credentials!</string>
+			<key>UIApplicationShortcutItemIconSymbolName</key>
+			<string>nosign</string>
+			<key>UIApplicationShortcutItemType</key>


Suggestion: UIApplicationShortcutItemType is typically an identifier (e.g. com.edge.app.contact_support), not a full URL.

Storing URLs there works, but it mixes identity with data. Consider using a type like contact_support and passing the URL via userInfo for clearer separation. The handleShortcutItem function would then switch on the type and look up the URL.

samholmes · 2026-02-20T20:14:31Z

android/app/src/main/res/xml/shortcuts.xml

+  <shortcut
+    android:shortcutId="contact_support"
+    android:enabled="true"
+    android:icon="@mipmap/ic_launcher"


Suggestion: Both Android shortcuts use the same app launcher icon (@mipmap/ic_launcher), making them visually identical.

iOS uses distinct SF Symbols (nosign and message.fill) for each shortcut. Consider using different icons for Android too to improve shortcut recognition and UX.

samholmes · 2026-02-20T20:14:38Z

ios/edge/AppDelegate.swift

+
+  private func handleShortcutItem(_ shortcutItem: UIApplicationShortcutItem) -> Bool {
+    guard let url = URL(string: shortcutItem.type) else { return false }
+


Suggestion: UIApplication.shared.open has a completion handler that could help with debugging or analytics.

UIApplication.shared.open(url, options: [:]) { success in if !success { // Log or handle failure } }

Not critical, but could be useful for future troubleshooting.

samholmes · 2026-02-20T20:14:45Z

ios/edge/AppDelegate.swift

 class AppDelegate: UIResponder, UIApplicationDelegate {
  var window: UIWindow?
  var securityView: UIView?
+  private var pendingShortcutItem: UIApplicationShortcutItem?


Suggestion: Consider adding a brief comment explaining why shortcut handling is deferred.

The pattern of storing pendingShortcutItem and handling it after React Native setup is useful but not immediately obvious. A comment like:

// Shortcut actions are deferred until React Native is fully initialized private var pendingShortcutItem: UIApplicationShortcutItem?

would clarify the intent for future readers.

samholmes · 2026-02-20T20:14:56Z

ios/edge/Info.plist

 	</array>
 	<key>CFBundleVersion</key>
 	<string>99999999</string>
+	<key>UIApplicationShortcutItems</key>


Localization: These shortcut strings are hardcoded in English only.

The app supports 13 locales via React Native (src/locales/strings/*.json), but these native shortcuts won't be translated.

Recommendation: Use InfoPlist.strings for localization:

Create ios/edge/en.lproj/InfoPlist.strings:

SHORTCUT_UNINSTALL_TITLE = "⚠️ Save 2FA First!"; SHORTCUT_SUPPORT_TITLE = "Contact Support";

Create locale-specific .lproj folders (e.g., es.lproj, de.lproj) with translated strings.

Update Info.plist to use the keys instead of hardcoded strings.

Similarly for Android, add values-es/strings.xml, values-de/strings.xml, etc.

This could be deferred to a follow-up PR, but should at least be documented as a known limitation.

Add two static shortcuts accessible via long-press on the app icon: - "Save 2FA First!" warning linking to the support article about getting a new phone and preserving credentials - "Contact Support" linking to live chat support iOS uses SF Symbols (nosign, message.fill) with shortcut types following reverse-DNS convention. Android uses system drawable icons (ic_dialog_alert, ic_menu_help) and native browser handling for https URLs to avoid misrouting through the deep link handler. Made-with: Cursor

Register Android strings.xml and iOS InfoPlist.strings as Crowdin source files so shortcut labels can be translated alongside existing in-app strings. Crowdin will generate locale-specific resource directories (values-*/strings.xml, *.lproj/InfoPlist.strings) when translations are submitted. Made-with: Cursor

JP0P requested a review from samholmes February 18, 2026 19:49

JP0P force-pushed the jared/cursor-agent/long-press-warning branch from 8ba3ec2 to 404fbc0 Compare February 18, 2026 22:14

samholmes requested changes Feb 20, 2026

View reviewed changes

JP0P force-pushed the jared/cursor-agent/long-press-warning branch 2 times, most recently from 854b747 to 01725a8 Compare March 30, 2026 17:28

j0ntz force-pushed the develop branch from 956a7c2 to 5fdf884 Compare March 30, 2026 18:06

JP0P added 2 commits March 31, 2026 18:30

JP0P force-pushed the jared/cursor-agent/long-press-warning branch from 2665230 to a1f8cef Compare April 1, 2026 01:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jared/cursor agent/long press warning#5950

Jared/cursor agent/long press warning#5950
JP0P wants to merge 2 commits intodevelopfrom
jared/cursor-agent/long-press-warning

JP0P commented Feb 18, 2026 •

edited

Loading

Uh oh!

samholmes left a comment

Uh oh!

samholmes Feb 20, 2026

Uh oh!

samholmes Feb 20, 2026

Uh oh!

samholmes Feb 20, 2026

Uh oh!

samholmes Feb 20, 2026

Uh oh!

samholmes Feb 20, 2026

Uh oh!

samholmes Feb 20, 2026

Uh oh!

samholmes Feb 20, 2026

Uh oh!

samholmes Feb 20, 2026

Uh oh!

samholmes Feb 20, 2026

Uh oh!

samholmes Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Platform	Contact Support (long)
Android	"Contact support for help from a live agent"
iOS	"Get help from our live support agents"

		<string name="shortcut_do_not_uninstall_short">⚠️ Save 2FA First!</string>
		<string name="shortcut_do_not_uninstall_long">⚠️ Login requires 2FA & credentials!</string>


		private func handleShortcutItem(_ shortcutItem: UIApplicationShortcutItem) -> Bool {
		guard let url = URL(string: shortcutItem.type) else { return false }

Conversation

JP0P commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CHANGELOG

Dependencies

Requirements

Uh oh!

samholmes left a comment

Choose a reason for hiding this comment

Review Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JP0P commented Feb 18, 2026 •

edited

Loading