Skip to content

ci/publish: node 24 + OIDC trusted publishing; drop EOL node 18#23

Merged
Shane98c merged 4 commits into
mainfrom
chore/node-24-ci-publish
Jun 23, 2026
Merged

ci/publish: node 24 + OIDC trusted publishing; drop EOL node 18#23
Shane98c merged 4 commits into
mainfrom
chore/node-24-ci-publish

Conversation

@Shane98c

@Shane98c Shane98c commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator
  • Publish workflow => npm OIDC trusted publishing on node 24 (no NPM_TOKEN; provenance kept). Also fixes the workflow, which had never successfully published.
  • CI node matrix => 20/22/24 (drop EOL 18, add 24); add engines.node >=20.

closes #4

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a RELEASING.md guide outlining the release process for the npm package and updates package.json to require Node.js version 20 or higher. Feedback on the release guide suggests adding a warning about manual publishing limitations, as npm OIDC trusted publishing might restrict manual publishing or fail to generate secure build provenance.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread RELEASING.md Outdated
3. `gh release create vX.Y.Z --generate-notes` — triggers the publish (the tag alone does not).
4. CI installs, tests, builds, and publishes. Verify with `npm view icechunk-js version`.

Manual fallback: `npm ci && npm run build && npm publish --access public`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With npm OIDC trusted publishing enabled, manual publishing via npm publish may be restricted by npm's security settings (which often require publishing exclusively via CI/provenance). Additionally, manual publishing will not generate the secure build provenance. Consider adding a warning note about this limitation.

@Shane98c Shane98c merged commit 748515c into main Jun 23, 2026
12 checks passed
@Shane98c Shane98c deleted the chore/node-24-ci-publish branch June 23, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup automatic CI provenance publishing to npm

1 participant