Add diagnostic to calculate hour of maximum precipitation#4334
Open
Add diagnostic to calculate hour of maximum precipitation#4334
Conversation
Contributor
Author
|
Doc build fail not related to this PR: #4333 |
Member
|
I get this error message from the diagnostic: |
Contributor
Author
|
Interesting, maybe it's because of an old version of numpy. Nevertheless, I replaced it with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a diagnostic and example recipe to calculate the maximum hour of precipitation. The following
methods can be selected in the recipe:"dft", apply a discrete Fourier transform (DFT) to the data and use the peak of the first component (see https://mdtf-diagnostics.readthedocs.io/en/latest/sphinx_pods/precip_diurnal_cycle.html)."harmonic_fit", fit a 12hr- plus 24hr-harmonic to the input data and use the peak of the 24hr-harmonic (see Dai, 2024; https://doi.org/10.1007/s00382-024-07182-6). This should give identical/very similar results to"dft", but is much slower."max", simply use the maximum in the input data.Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: