Skip to content

Make APPAR_TEMP and DISCOIS variables available when calc_human_stress_indices is FAST#4111

Open
olyson wants to merge 2 commits into
ESCOMP:b4b-devfrom
olyson:appartemp
Open

Make APPAR_TEMP and DISCOIS variables available when calc_human_stress_indices is FAST#4111
olyson wants to merge 2 commits into
ESCOMP:b4b-devfrom
olyson:appartemp

Conversation

@olyson

@olyson olyson commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description of changes

Make APPAR_TEMP and DISCOIS variables available when calc_human_stress_indices is FAST.
These variables do not depend on the more expensive wet bulb calculation (calc_human_stress_indices=ALL).
Accomplish this by moving these variables out from within this if block within HumanIndexMod.F90:

if ( all_human_stress_indices )then

Specific notes

Contributors other than yourself, if any:

  • J. Buzan

CTSM issues resolved or otherwise addressed, if any:
None

Any user interface changes (namelist or namelist defaults changes)?
No

Testing planned or performed, if any:

  • ./run_sys_tests -c ctsm5.4.044 --skip-generate -s clm_short --baseline-root /glade/campaign/cgd/tss/ctsm_baselines/ --account P93300041
    Results are bfb except for field list differences as expected:
0708-082809de_gnu: 2 tests
    FAIL ERP_D_P64x2_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_gnu.clm-default BASELINE ctsm5.4.044: FIELDLIST field lists differ (otherwise bit-for-bit)
    FAIL ERS_D_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_gnu.clm-default BASELINE ctsm5.4.044: FIELDLIST field lists differ (otherwise bit-for-bit)


0708-082809de_int: 5 tests
    FAIL ERP_D_P64x2_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel.clm-default BASELINE ctsm5.4.044: FIELDLIST field lists differ (otherwise bit-for-bit)
    FAIL ERP_D_P64x2_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel.clm-default--clm-matrixcnOn_ignore_warnings BASELINE ctsm5.4.044: FIELDLIST field lists differ (otherwise bit-for-bit)
    FAIL ERS_D_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel.clm-default BASELINE ctsm5.4.044: FIELDLIST field lists differ (otherwise bit-for-bit)
    FAIL SMS_D_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel.clm-default BASELINE ctsm5.4.044: FIELDLIST field lists differ (otherwise bit-for-bit)
    FAIL SMS_D_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel.clm-default--clm-matrixcnOn BASELINE ctsm5.4.044: FIELDLIST field lists differ (otherwise bit-for-bit)

Requirements before merge:

  • I have followed the CTSM contribution guidelines.
  • The code in this PR branch builds with no errors.
  • The code in this PR branch runs with no errors. Briefly describe tested configuration(s): clm_short
  • This either (a) does not change answers, (b) it only changes answers at roundoff level, or (c) I have performed a scientific evaluation of the answer changes. Which?: (a)
  • I have reviewed relevant parts of the CLM documentation Tech Note or User's Guide to determine if anything needs to be changed or added. If it does, describe: NA
  • This PR either (a) does not create a need to update the documentation or (b) includes required documentation updates (see guidelines for contributing documentation). Which?: (a)

@olyson olyson added next this should get some attention in the next week or two. Normally each Thursday SE meeting. b4b bit-for-bit labels Jul 8, 2026
@olyson

olyson commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

This was supposed to go on b4b-dev but somehow I've based this on main. Suggestions on how to fix this?

@olyson olyson changed the base branch from master to b4b-dev July 8, 2026 14:57
@olyson

olyson commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

This was supposed to go on b4b-dev but somehow I've based this on main. Suggestions on how to fix this?

Ok, I've fixed this.

@wwieder wwieder added this to the ctsm6.0.0 (code freeze) milestone Jul 9, 2026
@github-project-automation github-project-automation Bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Jul 9, 2026
@github-project-automation github-project-automation Bot moved this from Ready to start (or start again) to In progress - master in CTSM: Upcoming tags Jul 9, 2026
@wwieder wwieder moved this from In progress - master to In progress - b4b-dev in CTSM: Upcoming tags Jul 9, 2026
@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit

Projects

Status: In progress - b4b-dev

Development

Successfully merging this pull request may close these issues.

2 participants