CN allocation tech notes improvements#4020
Open
huiqi-wang wants to merge 1 commit into
Open
Conversation
8 tasks
8 tasks
Contributor
|
@slevis-lmwg do you mind reviewing this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Specific notes
Contributors other than yourself, if any:
CTSM issues resolved or otherwise addressed, if any:
references related:
Line 14, 16: Plant Respiration → Chapter :numref:rst_Plant Respiration
Line 14: Sprugel → :ref:Sprugel et al. (1995)Line 72: Larcher → :ref:Larcher (1995)
Line 81: Allen / Vanninen / Axelsson — all three are now :ref: Lines 72, 161: Table → :numref:Table Allocation and CN ratio parametersLines 163, 182: Equations → :eq:19.7,
:eq:19.9, :eq:19.10,:eq:19.11, :eq:19.12Lines 259, 335: FUN → Chapter :numref:rst_FUNBug fixes:
Line 72: g_l → g_1 (typo)
Line 79: parentheses fixed in the a_3 sigmoid → \frac{2.7}{1 + e^{-0.004 (NPP_{ann} - 300)}} - 0.4
Line 111: missing table row separator inserted (BDS boreal / C₃ arctic grass)
Line 194: CF_{alloc,leaf} → CF_{alloc,leaf_tot} (consistent with Eq. 19.14–19.25)
add more explanation and clarification:
Line 45: 86400 is now explained (s day⁻¹, converts τ from days to s)
Line 147: PFT abbreviation legend (NET/NDT/BET/BDT/BES/BDS + R/I)
Lines 64–70 & 154–159: Eqs. 19.7 and 19.9 use \begin{aligned} + \text{}
Line 256: section title capitalized "Nitrogen Allocation"
Line 85: table title "carbon:nitrogen" (not :)
Line 88: Target :math:CN_{...}`` (text outside math) — keep it consistant with similar item in CN Pools
If answers are expected to change, describe (delete this line otherwise):
Any user interface changes (namelist or namelist defaults changes)?
Testing planned or performed, if any:
Requirements before merge: