Mimics to merge#4010
Closed
wwieder wants to merge 5 commits into
Closed
Conversation
This reverts commit e8fb92b.
Contributor
Author
|
Something happened with this PR, as expected code changes aren't currently being shown, please treat as draft. |
Contributor
|
Superseded by #4014 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes overflow respiration error described in #3491
Specific notes
Contributors other than yourself, if any:
CTSM issues resolved or otherwise addressed, if any:
Resolves #3491
If answers are expected to change, describe (delete this line otherwise):
Yes, reduces N limitation in MIMICS simulations
Any user interface changes (namelist or namelist defaults changes)?
NA
Testing planned or performed, if any:
Requirements before merge:
The code in this PR branch builds with no errors.
The code in this PR branch runs with no errors. Briefly describe tested configuration(s):
This either (a) does not change answers, (b) it only changes answers at roundoff level, or (c) I have performed a scientific evaluation of the answer changes. Which?:
I have reviewed relevant parts of the CLM documentation Tech Note or User's Guide to determine if anything needs to be changed or added. If it does, describe:
Documentation for MIMICS still needed, see Docs needed: MIMICS #3166
This PR either (a) does not create a need to update the documentation or (b) includes required documentation updates (see guidelines for contributing documentation). Which?:
Documentation for MIMICS still needed, see Docs needed: MIMICS #3166