Skip to content

ctsm5.4.027: Important coupled model final answer changes: param file and n_melt_glcmec#3810

Open
ekluzek wants to merge 20 commits intoESCOMP:masterfrom
ekluzek:important_final_answer_changes
Open

ctsm5.4.027: Important coupled model final answer changes: param file and n_melt_glcmec#3810
ekluzek wants to merge 20 commits intoESCOMP:masterfrom
ekluzek:important_final_answer_changes

Conversation

@ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Mar 12, 2026

Description of changes

Some important final answer changes needed for the coupled model to get the right parameter file and to set n_melt_glcmec=1 for clm6_0.

Also use the 2015 finidat file for SSP future scenarios.

Specific notes

Contributors other than yourself, if any: @slevis-lmwg

CTSM Issues Fixed (include github issue #):
Fixees #3799
Fixes #3824
Fixes #3826
Fixes #3835
Fixes #3836

Are answers expected to change (and if so in what way)? Yes!
coupled model and clm60cam7LndTuning mode tests change answers due to parameter file
clm6_0 cases change answers because of change in n_melt_glcmec
  SSP cases change answers for cases where the finidat file changes

Any User Interface Changes (namelist or namelist defaults changes)? Yes
n_melt_glcmec is 1 for clm6_0
paramfile for clm6_0_cam7.0 changes
2015 finidat file for SSP cases starting in 2015
2010 finidat files will be used for clm6_0
2003 finidat file will be used for clm4_5 with cam6.0/cam7.0

Does this create a need to change or add documentation? Did you do so? No No

Testing performed, if any: Will do regular

@ekluzek ekluzek self-assigned this Mar 12, 2026
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations science Enhancement to or bug impacting science usability Improve or clarify user-facing options PR status: needs testing non-bfb Changes answers (incl. adding tests) size: small labels Mar 12, 2026
@github-project-automation github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Mar 12, 2026
@ekluzek ekluzek moved this from Ready to start (or start again) to In progress - master in CTSM: Upcoming tags Mar 12, 2026
@wwieder wwieder changed the title ctsm5.4.025: Important final answer changes ctsm5.4.026: Important final answer changes Mar 12, 2026
@ekluzek ekluzek changed the title ctsm5.4.026: Important final answer changes ctsm5.4.027: Important final answer changes Mar 12, 2026
@ekluzek ekluzek moved this from Todo to In Progress in LMWG: Sprint Planning Board Mar 13, 2026
Merge b4b-dev to master

Purpose and description of changes
----------------------------------

Merge b4b-dev to master:

Important things coming in:

 - mizuRoute! (NOTE: mizuRoute is a River model (ROF in the CESM context) that can be run in place of MOSART or RTM)
 - Documentation updates
 - Move a few namelist parameters to the parameter file
 - move of X components for nuopc
 - mksurfdata_esmf for Gnu compiler
 - scripts for CRUJRA forcing to handle Antarctica/Greenland
 - SpinupStablity script update to handle FATES and SE grids
 - Update cdeps for access to CMIP7 CO2
 - Tests for FATES Tree Recruitment Scheme (TRS)

Main grids to use with mizuRoute:

  Default mizuRoute grids will use the half degree land-only mizuRoute grid that is the same resolution as the MOSART grid.

  - 5x5_amazon_r05 - is the small Amazon region for testing
  - 5x5_amazon_rHDMA - is the small Amazon region using the HDMA for mizuRoute
  - nldas2_nldas2_rUSGS_mnldas2 - is the Continental US grid with USGS Geospatial Fabric
  - f09_f09_rHDMA_mg17 - is the 2 degree grid with the medium resolution HDMA grid
  - f09_f09_rHDMAlk_mg17 - is the 2 degree grid with the medium resolution HDMA grid that includes lakes
  - hcru_hcru_rMERIT_mt13 - is the half degree grid with the high resolution MERIT grid

Standard case to run with mizuRoute:

  grid=f09_f09_rHDMAlk_mg17 compset=I2000Clm60SpMizGs
@slevis-lmwg
Copy link
Contributor

@ekluzek from email conversation with Gunther:
"n_melt_glcmec =1 is our plan"

@ekluzek @wwieder does it make sense to bring in this one-liner for coupled cases using this PR?

@ekluzek ekluzek changed the title ctsm5.4.027: Important final answer changes ctsm5.4.027: Important coupled model final answer changes: param file and n_melt_glcmec, historical settings Mar 19, 2026
@ekluzek ekluzek changed the title ctsm5.4.027: Important coupled model final answer changes: param file and n_melt_glcmec, historical settings ctsm5.4.027: Important coupled model final answer changes: param file and n_melt_glcmec Mar 20, 2026
@ekluzek
Copy link
Collaborator Author

ekluzek commented Mar 20, 2026

Ran testing last night. I have some unexpected fails on Derecho to figure out, for mizuRoute tests. It looks like Izumi is good other than some current fails to read baselines. I also need to go over all the DIFF's and make sure they are correct.

@ekluzek ekluzek requested a review from slevis-lmwg March 20, 2026 15:58
Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ekluzek. I'm approving and simply asking a few questions to make sure that I follow.

Transfer biophysical variables for output with FATES dimensions

This pull request updates the high frequency wrapper procedure in the interface to pass
biophysical CLM variables to be output along FATES dimensions. The FATES land use x
pft dimension is also added to the history module.  The FATES base land use test module
adds the FATES history noted above to the test output.
@ekluzek
Copy link
Collaborator Author

ekluzek commented Mar 20, 2026

From what I can tell, the mizuRoute cases that didn't work were just a random fluke? I'm not figuring anything out that can reliably trigger it to fail.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Mar 20, 2026

NEON Clm60 cases are using the 2015 file rather than the 2000 file, because the date is closer. So this needs to be adjusted so that doesn't happen.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Mar 20, 2026

Fates tests are showing differences as well, because I didn't bring in ctsm5.4.026 when I started the testing.

In looking through the Izumi tests that differ from baseline, they all (other than the NEON and Fates ones) are correct. For clm6_0 n_melt_glcmec changes and the LndTuning mode test also uses the coupled param file as it should.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Mar 21, 2026

There's something going on with this case that gives a namelist difference to init_interp_fill_missing_urban_with_hd:

amelist diff between files SMS_Ld5.f10_f10_mg37.ISSP245Clm60BgcCropCrujra.derecho_gnu.clm-ciso_dec2050Start/CaseDocs/lnd_in and /glade/campaign/cgd/tss/ctsm_baselines/ctsm5.4.027/SMS_Ld5.f10_f10_mg37.ISSP245Clm60BgcCropCrujra.derecho_gnu.clm-ciso_dec2050Start/CaseDocs/lnd_in
  BASE: use_init_interp = T
  COMP: use_init_interp = .true.
  BASE: init_interp_fill_missing_urban_with_hd = .true.
  COMP: init_interp_fill_missing_urban_with_hd = .false.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Mar 23, 2026

@slevis-lmwg and I talked about this, this morning. We agreed that the 2015 file should just be used for clm4_5/clm5_0, so I'm setting it up that way. We also noticed that the 2010 files aren't being used most of the time, because they aren't listed in init_interp_sim_years. There's 2013 files just used for CONUS and 2003 files just used for clm5_0 coupled to cam6 or cam7 for f19.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Mar 23, 2026

OK, so now the special VR grids are matching the 2015 file, so there needs to be an explicit listing for use_init_interp of .false.for these cases.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Mar 23, 2026

OK, so now the special VR grids are matching the 2015 file, so there needs to be an explicit listing for use_init_interp of .false.for these cases.

Probably because of #3832 adding explicit lines for this to false didn't work. So there probably needs to be lines for init_interp_attributes for 2015 to exclude those grids as well? Or does there need to be a line for each resolution to point to a different sim_year finidat file?

ekluzek added 7 commits March 23, 2026 17:04
…ngs are done when the initial use_init_interp default setting is checked for (otherwise it would always be true since it couldn't distinquish by attributes)
Resolve ESCOMP#3835 by adding 2010 to init_interp_sim_years.
nit_interp_sim_years #
…_interp and init_interp_attributes and set 2003 finidat only once and use do_transient_pfts=.true.
…terp more robust, by calling it after the settings have been declared, rather than setting them only for the default run through
…th single vs double precision, larger changes to clm4_5 have already come in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement new capability or improved behavior of existing capability non-bfb Changes answers (incl. adding tests) PR status: needs testing priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations science Enhancement to or bug impacting science size: small usability Improve or clarify user-facing options

Projects

Status: In progress - master
Status: In Progress

2 participants