New documentation for the CTSM dust emission module#3624
New documentation for the CTSM dust emission module#3624dmleung wants to merge 8 commits intoESCOMP:b4b-devfrom
Conversation
|
Hi @samsrabin I do need to make a few more commits to clean up the doc, check section numbers, and add references before it's ready for review. I will make updates soon, but I do want to put a draft PR here. Thanks! |
|
I rebased this to come to b4b-dev rather than master. |
|
I rebased this to come in on b4b-dev rather than master. |
|
Oh, I don't know we are merging to b4b-dev. Thanks for doing that Erik! |
samsrabin
added
documentation
… pass the initial check.
|
Hi @samsrabin and @ekluzek, I just wanted to ping you and say that I think this PR is ready for review when you have time. |
ekluzek
left a comment
ekluzek
left a comment
There was a problem hiding this comment.
@dmleung thanks for your work here! It's nice to have this update in place, and not to have to worry about getting it in later.
I have a couple suggestions about handling "g" and changing rho _{a} to rho _{atm} as that seems to be more consistent in other places in the tech note. We should also just remove the details about Zender, as that will be documented in the CLM50 tech note, and it would be confusing here. You might mention it as the previous method and say details on it are in the CLM50 tech note. But, it adds too much complexity to give the full details of both here.
ekluzek
changed the title
|
@dmleung |
Hi Sam, yes! Is it okay if I try to finish it by this weekend so you can work on it next week? |
|
That sounds good. Thank you @dmleung! |
…nstants for the dust doc. Removed description of Zender 2003 dust emission scheme in the doc.
|
@slevis-lmwg @ekluzek |
slevis-lmwg
left a comment
slevis-lmwg
left a comment
There was a problem hiding this comment.
Requesting a correction that I noticed, and maybe I can resolve it myself.
| :label: 30.3 | ||
|
|
||
| where :math:`T` is a global factor that compensates for the DEAD model's sensitivity to horizontal and temporal resolution and equals 5 x 10\ :sup:`-4` in the CLM instead of 7 x 10\ :sup:`-4` in :ref:`Zender et al. (2003)<Zenderetal2003>`. :math:`S` is the source erodibility factor set to 1 in the CLM and serves as a place holder at this time. | ||
| w=\theta\frac{ \rho _{water} }{\rho_{bulk} } |
There was a problem hiding this comment.
| w=\theta\frac{ \rho _{water} }{\rho_{bulk} } | |
| w=\theta\frac{ \rho _{liq} }{\rho_{bulk} } |
4 participants
… New CTSM dust emission documentation by @dmleung.
Description of changes
This PR is on updating the ctsm tech note / documentation on the CTSM dust emission modules, Leung_2023 and Zender_2003.
Specific notes
Contributors other than yourself, if any:
@samsrabin @ekluzek
@tilmes
CTSM Issues Fixed (include github issue #):
#3170
Are answers expected to change (and if so in what way)?
No, this is a documentation to the dust emission module
Any User Interface Changes (namelist or namelist defaults changes)?
No
Does this create a need to change or add documentation? Did you do so?
This PR is on changing the documentation.
Testing performed, if any: