[feat] Posthog 이벤트 수정 및 신규 생성#527
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request expands analytics tracking across the application, including login, map interactions, My Page navigation, and home screen widgets. It also updates review events to include restaurant metadata and adds locale information to app launch logs. Review feedback identifies a bug where college and department IDs were swapped in an analytics event, and suggests improvements for code deduplication and consistent validation of widget IDs.
| val newDepartmentId = userCollegeDepartment.userDepartment.departmentId.toLong() | ||
| val newCollegeId = userCollegeDepartment.userCollege.collegeId.toLong() | ||
|
|
||
| analyticsTracker.track( | ||
| ClickPlzNotMeEvent( | ||
| college = newDepartmentId, | ||
| major = newCollegeId, |
There was a problem hiding this comment.
The parameters for ClickPlzNotMeEvent appear to be swapped. newDepartmentId is being passed to college and newCollegeId to major, which contradicts their names and the pattern used in trackMyPageMenu.
| val newDepartmentId = userCollegeDepartment.userDepartment.departmentId.toLong() | |
| val newCollegeId = userCollegeDepartment.userCollege.collegeId.toLong() | |
| analyticsTracker.track( | |
| ClickPlzNotMeEvent( | |
| college = newDepartmentId, | |
| major = newCollegeId, | |
| val collegeId = userCollegeDepartment.userCollege.collegeId.toLong() | |
| val departmentId = userCollegeDepartment.userDepartment.departmentId.toLong() | |
| analyticsTracker.track( | |
| ClickPlzNotMeEvent( | |
| college = collegeId, | |
| major = departmentId, | |
| ), | |
| ) |
| val fileKey = | ||
| appWidgetId?.takeIf { it != AppWidgetManager.INVALID_APPWIDGET_ID } | ||
| ?.let { "appWidget-$it" } |
There was a problem hiding this comment.
The logic for generating the fileKey is repeated in multiple places. Consider creating a private helper function or a constant to ensure consistency and reduce duplication.
| } | ||
|
|
||
| lifecycleScope.launch { | ||
| val fileKey = "appWidget-$appWidgetId" |
There was a problem hiding this comment.
In onConfirm, appWidgetId is used directly without checking if it is AppWidgetManager.INVALID_APPWIDGET_ID, unlike the logic in LaunchedEffect. It's safer to use the same validation logic here.
1 participant
Summary
Describe your changes
app_launch에서 현재 설정 언어의localeCode전송click_mypage_menu,popup_event신규 추가change_widgetpayload를restaurant_before,restaurant_after로 변경food_court,the_kitchen은 analytics restaurant payload에서 제외write_review_v2,complete_review_v2에 restaurant 값 전달Issue
To reviewers