[feat] 만든 사람들 노션 페이지로 이어지도록 수정#525
Open
chlwhdtn03 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the local DeveloperActivity with a web view pointing to an external URL for the 'Developers' page. Feedback suggests using ScreenId.MYPAGE_DEVELOPER instead of ScreenId.EXTERNAL_TERMS for consistent analytics tracking and recommends removing the now-obsolete DeveloperActivity and its associated layout file to maintain project cleanliness.
I am having trouble creating individual review comments. Click here to see my feedback.
app/src/main/java/com/eatssu/android/presentation/mypage/MyPageFragment.kt (145)
onDeveloperClick에서 ScreenId.EXTERNAL_TERMS를 사용하고 있습니다. '만든 사람들' 페이지는 약관(Terms)과는 성격이 다르므로, 기존 DeveloperActivity에서 사용하던 ScreenId.MYPAGE_DEVELOPER를 사용하는 것이 분석 데이터의 일관성 측면에서 더 적절합니다.
ScreenId.MYPAGE_DEVELOPER
app/src/main/java/com/eatssu/android/presentation/mypage/MyPageFragment.kt (142-146)
이번 변경으로 DeveloperActivity의 호출부가 제거되었습니다. 해당 액티비티와 관련 리소스(activity_developer.xml)가 더 이상 사용되지 않는다면, 프로젝트 유지보수를 위해 삭제하는 것을 권장합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
113차 회의에서 한번 더 전달받은 대로 마이페이지의 [만든 사람들] 버튼을 눌렀을 때 앱 내 액티비티가 아닌 웹뷰를 통해 노션페이지로 이동하도록 수정했습니다.
Describe your changes
Issue
To reviewers