Skip to content

Make landIceDraft diagnostic rather than a forcing variable#125

Closed
cbegeman wants to merge 10 commits intoE3SM-Ocean-Discussion:masterfrom
cbegeman:ocn/remove-land-ice-draft-forcing
Closed

Make landIceDraft diagnostic rather than a forcing variable#125
cbegeman wants to merge 10 commits intoE3SM-Ocean-Discussion:masterfrom
cbegeman:ocn/remove-land-ice-draft-forcing

Conversation

@cbegeman
Copy link
Copy Markdown
Collaborator

@cbegeman cbegeman commented Mar 16, 2025

Formerly, landIceDraft was provided along with landIcePressure as a forcing variable. With this PR, landIceDraft is computed from landIcePressure as an ocean diagnostic using a reference ocean density provided as a new config option. In future configurations in which MALI and MPAS-Ocean are coupled, there should be a mechanism for ensuring consistency of this parameter in both components.

This PR is non-BFB because land ice draft is used to compute pressure-adjusted SSH from which the coupled variable gradSSH is computed.

[NCC]

@cbegeman cbegeman requested a review from xylar March 16, 2025 21:54
@cbegeman
Copy link
Copy Markdown
Collaborator Author

@xylar You may wait to review until I post a Compass PR for testing these changes

@cbegeman
Copy link
Copy Markdown
Collaborator Author

cbegeman commented Mar 16, 2025

Testing

This branch has been run on Chrys with intel, open-mpi with the ISOMIP+ Ocean0 test MPAS-Dev/compass#896. The landIceDraft differences from master are consistent with a different ocean density being used in Compass than the namelist default from MALI.

The e3sm_prod and e3sm_cryo_developer suites run on chrys, intel with diffs. All tests have ice shelf cavities, so diffs are expected

@xylar xylar changed the base branch from master to alternate April 1, 2025 15:22
@xylar xylar changed the base branch from alternate to master April 1, 2025 15:22
Copy link
Copy Markdown
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbegeman, I took a look at these code changes. I think this looks great and is ready for a longer simulation needed for it to go into E3SM.

Comment on lines +1081 to +1084
<nml_option name="config_land_ice_flux_rho_ocean" type="real" default_value="1028.0" units="kg m^-3"
description="ocean density used to calculate landIceDraft at floatation (assumed constant and uniform). Should be consistent with MALI's config_ocean_density. This is an alternative to the coupler variable effectiveDensityInLandIce which is not currently used."
possible_values="Any positive real number"
/>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Slack, let's maybe move this to a different (new?) namelist section and remove flux from the name.

@cbegeman
Copy link
Copy Markdown
Collaborator Author

@xylar I know you're out of the office at the moment. Would you like to look at the simulation results before I migrate to E3SM?

@xylar
Copy link
Copy Markdown
Collaborator

xylar commented Apr 29, 2025

I think you can go ahead and move to E3SM. I'll take a look when I can but it sounds promising from your description.

@cbegeman
Copy link
Copy Markdown
Collaborator Author

Closed in favor of E3SM-Project#7301

@cbegeman cbegeman closed this Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants