Add signal_buffer_leak example for memory leak detection#2569
Add signal_buffer_leak example for memory leak detection#2569bangarumahesh22 wants to merge 1 commit intoDynamoRIO:masterfrom
Conversation
| @@ -0,0 +1,16 @@ | |||
| #include <stdlib.h> | |||
There was a problem hiding this comment.
As in #2567, I am a little confused: so you are proposing creating a new directory examples/? Will these be used in automated tests? What is the bigger picture here: could you file a feature issue in the tracker and describe the goal and link this PR to that new issue?
There was a problem hiding this comment.
Thank you @derekbruening for reviewing this PR as well.
As I mentioned in #2567 and #2568, you're correct - this PR is also creating a new example file (examples/signal_buffer_leak.c), not editing an existing file.
I've responded to your questions about the bigger picture in the other PRs, and the same applies here:
Key points:
- All three PRs (Fix memory leak in test example #2567, Add second memory leak #2568, Add signal_buffer_leak example for memory leak detection #2569) were Hacktoberfest contributions submitted without proper planning
- I should have discussed creating an
examples/directory before implementing - I don't have a clear integration plan for automated tests or documentation
Proposal:
Since all three PRs suffer from the same issues, I'm proposing to:
- Close all three PRs as they weren't properly thought through
- If you think example files would benefit the project, I can file a feature request with:
- Clear purpose and use cases
- Integration plan with documentation/tests
- Which examples would be most valuable
- Wait for maintainer feedback before creating any new PRs
I apologize for the confusion and for not following proper contribution procedures. Should I proceed with closing these PRs?
| #include <stdlib.h> | ||
| #include <stdio.h> | ||
|
|
||
| #define SIGNAL_SIZE 1000 |
There was a problem hiding this comment.
Please explain in comments why this is called "signal": is this related to UNIX signals, or not?
This PR adds a simple signal buffer example demonstrating a memory leak scenario in an ECE signal processing context. Verified using Dr. Memory.