⎕FMT, ⎕TRAP, ⎕UCS: special control chars NEED to be uppercase - #965
Open
bear8642 wants to merge 1 commit into
Hidden character warning
The head ref may contain hidden characters: "806-\u2395fmt-\u2395trap-\u2395ucs-special-control-chars-need-to-be-uppercase"
Open
⎕FMT, ⎕TRAP, ⎕UCS: special control chars NEED to be uppercase#965bear8642 wants to merge 1 commit into
bear8642 wants to merge 1 commit into
Conversation
FionaDyalog
approved these changes
Aug 3, 2026
FionaDyalog
left a comment
FionaDyalog
left a comment
Contributor
There was a problem hiding this comment.
Approved on the assumption that all changes mentioned are implemented.
| The surrounding affixture delimiters may be replaced by the alternative pairs described for Text Insertion. | ||
|
|
||
| !!! Warning "Warning" | ||
| Note, the affixtures, qualifiers and control phrases must be specified in upper case. |
Contributor
There was a problem hiding this comment.
Suggested change
| Note, the affixtures, qualifiers and control phrases must be specified in upper case. | |
| The affixtures, qualifiers, and control phrases are case-sensitive and must be specified in upper case. |
|
|
||
| The surrounding affixture delimiters may be replaced by the alternative pairs described for Text Insertion. | ||
|
|
||
| !!! Warning "Warning" |
Contributor
There was a problem hiding this comment.
This does not need to be an admonition, and especially not a warning (not using upper case just generates an error message) – convert into a sentence instead.
| |`N`|Next|The event is excluded from the current `⎕TRAP` definition. The search will continue through further localised definitions of `⎕TRAP` .| | ||
| |`S`|Stop|Stops the search and causes the normal APL action to be taken in the environment in which the event occurred.| | ||
|
|
||
| !!! Warning "Warning" |
Contributor
There was a problem hiding this comment.
This does not need to be an admonition, and especially not a warning (not using upper case just generates an error message) – convert into a sentence instead.
| |`S`|Stop|Stops the search and causes the normal APL action to be taken in the environment in which the event occurred.| | ||
|
|
||
| !!! Warning "Warning" | ||
| Note, the ACTION codes must be specified in upper case. |
Contributor
There was a problem hiding this comment.
Suggested change
| Note, the ACTION codes must be specified in upper case. | |
| The action codes are case-sensitive and must be specified in upper case. |
| - `'UTF-32'` | ||
|
|
||
| !!! Warning "Warning" | ||
| Note, the encoding scheme value must be in specified upper case. |
Contributor
There was a problem hiding this comment.
Suggested change
| Note, the encoding scheme value must be in specified upper case. | |
| The encoding scheme value is case-sensitive and must be specified in upper case. |
| - `'UTF-16'` | ||
| - `'UTF-32'` | ||
|
|
||
| !!! Warning "Warning" |
Contributor
There was a problem hiding this comment.
This does not need to be an admonition, and especially not a warning (not using upper case just generates an error message) – convert into a sentence instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As #806 describes, warn that special codes must be in upper case