refactor(guest-agent): isolate simulator from production paths#582
Open
refactor(guest-agent): isolate simulator from production paths#582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens the guest-agent / simulator boundary and removes several design smells around simulated attestation handling.
What changed
dstack-guest-agent-simulatorcrate/binarydstack-guest-agentcrate and into the simulator crateAppInfocert-client, socert-clientnow only signs CSRsWhy
Previously, simulator behavior was mixed into the same guest-agent binary and selected by runtime configuration. That made the trust boundary fuzzy and increased the risk of accidentally routing production paths through simulated attestation behavior.
This PR makes the separation much stricter:
cert-clientonly transports/signs themValidation
Ran successfully:
cargo check -p cert-client -p dstack-guest-agent -p dstack-guest-agent-simulator -p dstack-utilcargo test -p dstack-guest-agent --libcargo test -p dstack-guest-agent-simulatorcd sdk/simulator && ./build.shCommits
refactor(guest-agent): isolate simulator into standalone binaryrefactor(cert): remove attestation override from shared flowrefactor(simulator): move simulator helpers out of guest-agent craterefactor(cert): move csr assembly out of cert-client