kms: require attestation for all KMS flows#579
Merged
Conversation
93f467b to
c8cddc3
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on top of #573, this PR removes the KMS
quote_enabledsplit and makes attestation mandatory for all KMS flows.Changes:
core.onboard.quote_enabledfrom KMS configGetKmsKeyauth-simplesokms.mrAggregated = []is deny-all for KMS, matching the allowlist semantics used by on-chain authtests/docs/kms-bootstrap-onboard.mdand expand the manual test docs with bootstrap / onboard / trusted-RPC deny casesRationale
The old
quote_enabledswitch left KMS with two different security models:That made bootstrap / onboard / trusted RPC behavior harder to reason about, and produced awkward partial-compatibility cases where one side skipped a new check but another side still required attestation.
This PR makes the model explicit and uniform:
sdk/simulatorauth-simplenow uses a real MR allowlist instead of treating an empty list as "allow any"Validation
cargo fmt --allcargo check -p dstack-kmscargo clippy -p dstack-kms --all-targets -- -D warningscd kms/auth-simple && bun run test:runcd kms/auth-simple && bun run lintNotes
This is a stacked PR.
kms-bootstrap-onboard-auth-checksmaster