fix(gateway): redact cf_api_token in ListDnsCredentials response#578
Merged
fix(gateway): redact cf_api_token in ListDnsCredentials response#578
Conversation
The ListDnsCredentials API was returning the full Cloudflare API token in plaintext. Redact it to show only the first and last 4 characters (e.g., "pSFc...lQs") to prevent credential leakage via the admin API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cf_api_tokeninListDnsCredentialsAPI response to prevent credential leakagepSFc...lQs(first 4 + last 4 chars), tokens <= 8 chars are fully maskedFound during gateway cluster deployment —
ListDnsCredentialswas syncing and exposing the full Cloudflare API token in plaintext.Test plan
cargo check -p dstack-gatewaypasses