feat: Dhizuku installer UI and Japanese strings#1347
Open
zerofrip wants to merge 4 commits into
Open
Conversation
Build deps, AIDL, privileged UserService, install client, DhizukuInstaller adapter, InstallerType.DHIZUKU, and settings picker label. Replacement stack for closed Droid-ify#1339 (PR C of 5).
SyncService sequential batch, DownloadService.enqueueAndAwait, Dhizuku readiness gates. Replacement stack for closed Droid-ify#1339 (PR D of 5).
Settings permission gating, app-detail install/uninstall UX, error dialog, English and Japanese strings. Replacement stack for closed Droid-ify#1339 (PR E of 5).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SettingsViewModel.handleDhizukuInstaller()permission gatingDhizukuErrorDialog, uninstall confirmPR E of 5 — final feature PR; replacement stack for closed #1339.
Depends on: #1344–#1346 (PRs B–D). Rebase onto
mainas predecessors merge.Test plan
./gradlew :app:assembleDebug./gradlew :app:testDebugUnitTestAlso merge #1343 (receiver fix) for correct package broadcasts on API 33+.
Made with Cursor