feat: use native macOS window frame on Apple Silicon#907
Open
ZiWei09 wants to merge 1 commit into
Open
Conversation
On macOS, skip the Windows-style frameless window with custom TitleBar and resize Borders. Use Qt::Window with native decorations instead. Add NULL guards for _titleBar since it's not created on macOS. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the Windows-style custom titlebar and resize borders with the native macOS window frame on
Q_OS_DARWIN. The customFramelessWindowHintapproach looks out of place on macOS and causes usability issues.Changes
DSView/pv/mainframe.cpp: On macOS, useQt::Windowinstead ofFramelessWindowHint, skip creatingTitleBarandBorderwidgets, useQGridLayoutdirectly for the main windowDSView/pv/mainwindow.cpp: Add#ifndef Q_OS_DARWINguard fortitle_barassertion since it'sNULLon macOSTested
#ifdef Q_OS_DARWIN)Screenshot
Before: Custom Windows-style titlebar with DSL logo, minimize/maximize/close buttons
After: Native macOS window frame with standard traffic light buttons and proxy icon
This addresses the request for native macOS arm64 builds (see v1.3.2-arm64 release with prebuilt .dmg at https://github.com/ZiWei09/DSView/releases).