Live-tuning panel: change the look while you are looking at it - #83
Open
hernan0078 wants to merge 1 commit into
Open
Live-tuning panel: change the look while you are looking at it#83hernan0078 wants to merge 1 commit into
hernan0078 wants to merge 1 commit into
Conversation
Every row this mod owns is judged with the eyes, and OPTIONS covers the thing being judged. START, OPTION, step, B, B, look, decide, back again -- long enough to forget what STRONG looked like before seeing MEDIUM. A translucent handle in the top-right opens a small panel of the same rows over the running world. Stepping a value re-renders the next frame with it, so the comparison is immediate. It owns no settings of its own: every row calls the same ModSetting:cycle / Pipelines.cycle the OPTIONS row calls, and is handed the live Game so the change persists the same way. The two menus cannot disagree about what is set. `when` is honoured, so a row OPTIONS hides is hidden here too. Drawn after Game:draw, on the composited frame, in window units. Drawing it inside the 3D overlay put it upstream of the tilt-shift blur, so the handle came out soft inside MINIATURE blurred band -- and that pass only runs on a 3D rung, so the panel could not be used to switch 3D on in the first place. Drawing last fixes both. Installed after FirstPerson so it gets first refusal on a touch: first person claims anything on open screen as a look drag. TUNE PANEL turns it off, and is marked full so the preset cannot take away the switch that brings it back. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every setting this mod owns is judged with the eyes — and the OPTIONS menu covers the thing being judged. START, OPTION, step a row, B, B, look, decide, go back: long enough to forget what
STRONGlooked like by the time you seeMEDIUM.This adds a translucent handle in the top-right corner. Tapping it opens a small panel of the same rows over the running world; tap the left half of a row to step down, the right half to step up. The world redraws behind the panel, so you compare by looking rather than by walking back and forth.
It owns no settings of its own. Every row calls the same
ModSetting:cycle/Pipelines.cyclethe OPTIONS row calls, and is handed the liveGameso the change persists identically — the two menus cannot drift into disagreeing.whenis honoured, so a row OPTIONS hides is hidden here too.Two things I got wrong first, in case the reasoning is useful:
HordeHud. That canvas is upstream of the tilt-shift blur, so the handle came out soft insideMINIATUREs blurred band — and that pass only runs on a 3D rung, so the panel could not be used to switch 3D on. Drawing afterGame:drawfixes both.FirstPerson, which claims any touch on open screen as a look drag and swallowed every tap on the handle. Install order matters here.TUNE PANELturns it off, markedfullso the preset cannot remove the switch that brings it back.Bigger and more opinionated than my other PRs, so a straight no is a fine answer — I will keep carrying it either way. Tested on a physical iPhone; the mod tier passes in my tree apart from a
pushBattlefailure that predates the branch.