Name the settings for what they do, not what they are called internally - #80
Open
hernan0078 wants to merge 1 commit into
Open
Name the settings for what they do, not what they are called internally#80hernan0078 wants to merge 1 commit into
hernan0078 wants to merge 1 commit into
Conversation
AA, V-GRID, V-CURVE, T-SHIFT and VOXEL are the internal names of the systems behind them, and a player reading the OPTIONS menu has no way to guess what any of them change. Renamed for the effect rather than the implementation: AA -> SMOOTHING V-GRID -> BLOCK EDGES (the voxel seams, 3D Dot Game Heroes style) V-CURVE -> ROUND WORLD (the Animal Crossing horizon) T-SHIFT -> MINIATURE (what the tilt-shift blur reads as) 3D-BTL -> 3D BATTLES VOXEL -> 3D WORLD And the two numbered ladders say which direction they go: the curve and the tilt-shift now read OFF / LIGHT / MEDIUM / STRONG rather than OFF / 1 / 2 / 3, which does not say whether 3 is more or less of the thing. Every name still fits the value column. Tests updated. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taste rather than a bug, so entirely your call — but I watched someone open OPTIONS, read
AA,V-GRID,V-CURVE,T-SHIFT, and have no idea which one to touch to make the world look different.AASMOOTHINGV-GRIDBLOCK EDGESV-CURVEROUND WORLDT-SHIFTMINIATURE3D-BTL3D BATTLESVOXEL3D WORLDPlus the two numbered ladders.
OFF / 1 / 2 / 3does not say whether 3 is more of the effect or less;OFF / LIGHT / MEDIUM / STRONGdoes.I named
BLOCK EDGESandROUND WORLDfrom reading what the modules do rather than from the abbreviations, so tell me if I have described either one wrong.Everything still fits the value column. Tests updated. Happy to take any subset of this — the numbered ladders are the ones I would keep if you only wanted one.