Shorten the 1ST rung label so it fits on a phone screen - #79
Open
hernan0078 wants to merge 1 commit into
Open
Conversation
At 18 characters '1ST (EXPERIMENTAL)' is wider than the value column, so on a phone the rung is drawn past the right edge of the 160px screen and reads as missing -- the row appears to stop at 75 and players conclude first person is not in the build. It is selectable the whole time. The Game Boy screen is 160px and OptionRows draws a value at x=24, so a value has about 17 characters before it runs off. '1ST' is what the mode is called everywhere else in the code (FP_LEVEL, isFirstPerson), and the experimental status is already in the mod description and the changelog. Tests updated for the new label. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a phone the VOXEL row appears to stop at
75— the first-person rung looks like it is missing from the build. It is not:1ST (EXPERIMENTAL)is 18 characters, and the Game Boy screen is 160px withOptionRowsdrawing a value at x=24, which leaves room for about 17. The label is drawn past the right edge.I hit this on iOS and assumed for a while that first person had not shipped. Android has the same 160px screen, so it should be identical there.
1STis what the mode is called everywhere else in the code —FP_LEVEL,isFirstPerson— and the experimental status is already stated in the mod description and the changelog, which is where a player reads it rather than in a menu cell.Tests updated. Happy to use a different short label if you prefer one.