Fixes and more#3526
Open
GuillaumeDSM wants to merge 16 commits into
Open
Conversation
Herklos
reviewed
Jul 9, 2026
| @@ -0,0 +1,7 @@ | |||
| { | |||
Herklos
reviewed
Jul 9, 2026
| result_data = await handle.get_result() | ||
| except Exception as e: | ||
| result_data = {"error": str(e)} | ||
| except Exception as error: |
Contributor
There was a problem hiding this comment.
reminder to continue review here 😄
GuillaumeDSM
force-pushed
the
fixes
branch
3 times, most recently
from
d769b8d to
923a47d
Compare
Herklos
reviewed
Jul 10, 2026
| id=octobot_node.constants.NON_TRADING_GENERIC_PROCESS_OCTOBOT_STRATEGY_ID, | ||
| version=octobot_node.constants.NON_TRADING_GENERIC_PROCESS_OCTOBOT_STRATEGY_VERSION, | ||
| name="Generic process OctoBot strategy", | ||
| reference_market="USDC", |
Contributor
There was a problem hiding this comment.
Shouldn't we use a more global constant for this value ?
Member
Author
There was a problem hiding this comment.
right, i'll change this
| return now_ms - int(retention_seconds * 1000) | ||
|
|
||
|
|
||
| def get_outdated_automation_execution_deletions( |
Member
Author
|
thanks, it's up ! |
GuillaumeDSM
commented
Jul 10, 2026
Comment on lines
-691
to
-705
| ref_src = source_reference_tentacles_config or os.path.join( | ||
| working_directory, commons_constants.USER_FOLDER, "reference_tentacles_config" | ||
| ) | ||
| ref_src = os.path.normpath(ref_src) | ||
| ref_dst = os.path.join(user_root, "reference_tentacles_config") | ||
| if os.path.isdir(ref_src): | ||
| if os.path.exists(ref_dst): | ||
| shutil.rmtree(ref_dst) | ||
| shutil.copytree(ref_src, ref_dst) | ||
| else: | ||
| os.makedirs(ref_dst, exist_ok=True) | ||
|
|
||
| # Marker last: if anything above failed, a partial tree will not look "prepared". | ||
| with open(marker_path, "w", encoding="utf-8") as marker_file: | ||
| marker_file.write("1") |
Herklos
approved these changes
Jul 10, 2026
Herklos
approved these changes
Jul 11, 2026
GuillaumeDSM
force-pushed
the
fixes
branch
2 times, most recently
from
1535d30 to
dcc5963
Compare
Herklos
approved these changes
Jul 11, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires #3520