Skip to content

[DSL] add price operator and support indirect symbols#3471

Merged
GuillaumeDSM merged 1 commit into
devfrom
price_op
May 22, 2026
Merged

[DSL] add price operator and support indirect symbols#3471
GuillaumeDSM merged 1 commit into
devfrom
price_op

Conversation

@GuillaumeDSM
Copy link
Copy Markdown
Member

No description provided.

@GuillaumeDSM GuillaumeDSM self-assigned this May 22, 2026
@GuillaumeDSM GuillaumeDSM requested a review from Herklos as a code owner May 22, 2026 10:00
self, exchange_manager: typing.Optional[octobot_trading.exchanges.ExchangeManager]
):
if exchange_manager is not None:
self.symbol = exchange_manager.get_exchange_symbol(self.symbol)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converts token address to unified symbol when exchange supports it

Copy link
Copy Markdown
Contributor

@Herklos Herklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature 👍


def get_exchange_symbol_data(symbol, allow_creation=True):
if symbol not in PRICES_BY_SYMBOL:
raise octobot_commons.errors.InvalidParametersError(f"Symbol {symbol} not found")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +311 to +315
pytest.param(
"price",
[],
id="price",
),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GuillaumeDSM GuillaumeDSM enabled auto-merge (rebase) May 22, 2026 10:04
@GuillaumeDSM GuillaumeDSM merged commit bff1f4b into dev May 22, 2026
22 checks passed
@GuillaumeDSM GuillaumeDSM deleted the price_op branch May 22, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants