Node state & user actions executors#3460
Open
GuillaumeDSM wants to merge 5 commits into
Open
Conversation
GuillaumeDSM
force-pushed
the
node_state
branch
4 times, most recently
from
6a4ea91 to
ec76bee
Compare
Herklos
reviewed
May 13, 2026
Comment on lines
+78
to
+80
| def _derive_aes_key(self, wallet_private_key: str) -> bytes: | ||
| # Derive a 32-byte AES key from the wallet private key string using SHA-256. | ||
| return hashlib.sha256(wallet_private_key.encode("utf-8")).digest() |
Contributor
There was a problem hiding this comment.
We should prefer HKDF (HMAC-based Key Derivation Function) from wallet private key (more secure than the current sha256), or even better from the signature of the salt (more secure that HKDF with wallet private key and so with AES key from private key sha256).
| if workflow.workflow_id[:octobot_node.constants.PARENT_WORKFLOW_ID_LENGTH] in parent_workflow_ids | ||
| ] | ||
|
|
||
| async def resolve_active_automation_workflow_ids_for_parent_id( |
| import octobot_node.errors as node_errors | ||
|
|
||
|
|
||
| _DEFAULT_EXCHANGE_TYPE = "spot" |
Contributor
There was a problem hiding this comment.
Shouldn't it be provided in the protocol instead?
| @@ -1,3 +1,3 @@ | |||
| starfish-sdk==2.0.0 | |||
| starfish-sdk==2.3.0 | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.