Merged
Conversation
Comment on lines
+641
to
+648
| async def test_single_comparison(interpreter): | ||
| assert await interpreter.interprete("1 < 2") is True | ||
| assert await interpreter.interprete("2 < 1") is False | ||
| assert await interpreter.interprete("5 <= 5") is True | ||
| assert await interpreter.interprete("5 >= 5") is True | ||
| assert await interpreter.interprete("5 > 3") is True | ||
| assert await interpreter.interprete("3 == 3") is True | ||
| assert await interpreter.interprete("3 != 4") is True |
Member
There was a problem hiding this comment.
I think this is already covered in test_interpreter_basic_operations
Comment on lines
+713
to
+718
| async def test_chained_comparison_with_is_not(interpreter): | ||
| # x is not None and 0 < x <= 300000 | ||
| # This mirrors the original failing DSL script pattern | ||
| assert await interpreter.interprete("100 is not None") is True | ||
| assert await interpreter.interprete("None is None") is True | ||
| assert await interpreter.interprete("None is not None") is False |
Member
There was a problem hiding this comment.
I think this is already covered in test_interpreter_basic_operations
Comment on lines
+731
to
+738
| async def test_chained_comparison_combined_with_bool_ops(interpreter): | ||
| # chained comparison inside a boolean expression | ||
| # (0 < 5 <= 10) and (1 < 2) => True and True => True | ||
| assert await interpreter.interprete("0 < 5 <= 10 and 1 < 2") is True | ||
| # (0 < 5 <= 10) and (2 < 1) => True and False => False | ||
| assert await interpreter.interprete("0 < 5 <= 10 and 2 < 1") is False | ||
| # (0 < 15 <= 10) or (1 < 2) => False or True => True | ||
| assert await interpreter.interprete("0 < 15 <= 10 or 1 < 2") is True |
Member
There was a problem hiding this comment.
I think this is already covered in test_interpreter_mixed_basic_operations
Herklos
force-pushed
the
feature/add-dsl-multi-operations
branch
from
746e330 to
0c087f3
Compare
Member
Author
|
Thanks! It's up |
Signed-off-by: Herklos <herklos@drakkar.software>
Herklos
force-pushed
the
feature/add-dsl-multi-operations
branch
from
0c087f3 to
abf164b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.