Skip to content

fix some linting errors#1371

Merged
joshunrau merged 3 commits into
DouglasNeuroInformatics:mainfrom
joshunrau:release-changes
Jun 4, 2026
Merged

fix some linting errors#1371
joshunrau merged 3 commits into
DouglasNeuroInformatics:mainfrom
joshunrau:release-changes

Conversation

@joshunrau
Copy link
Copy Markdown
Collaborator

@joshunrau joshunrau commented Jun 4, 2026

Summary by CodeRabbit

  • Chores

    • Updated internal code organization and refined TypeScript type handling across multiple modules.
  • Refactor

    • Streamlined linting configuration structure for improved maintainability.

@joshunrau joshunrau merged commit 433bab8 into DouglasNeuroInformatics:main Jun 4, 2026
1 check was pending
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8c2dbccc-0ad9-4fd4-b0a5-0d6a3a81db2b

📥 Commits

Reviewing files that changed from the base of the PR and between 32081f4 and cb796dc.

📒 Files selected for processing (3)
  • apps/api/src/demo/demo.service.ts
  • apps/web/src/routes/_app/user.tsx
  • apps/web/src/utils/upload.ts

Walkthrough

This PR consolidates linting directives, removes an unused type import, and eliminates redundant TypeScript casts across three files. No runtime behavior is modified.

Changes

Cleanup and type improvements

Layer / File(s) Summary
Unused import cleanup
apps/api/src/demo/demo.service.ts
Removes the unused Json type from the type-only import from @opendatacapture/schemas/core.
Eslint directive consolidation
apps/web/src/routes/_app/user.tsx
Adds a file-level /* eslint-disable perfectionist/sort-objects */ directive and removes three inline eslint-disable comments from schema field definitions and form configuration.
TypeScript type cast removal in CSV processing
apps/web/src/utils/upload.ts
Removes explicit type casts: the { [key: string]: z3.ZodTypeAny } cast from schema shape assignment and the FormTypes.Data cast when pushing parsed CSV records.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant