Add try await keywords when chopping veggies#44
Open
ryansobol wants to merge 1 commit intoDougGregor:structured-concurrencyfrom
Open
Add try await keywords when chopping veggies#44ryansobol wants to merge 1 commit intoDougGregor:structured-concurrencyfrom
ryansobol wants to merge 1 commit intoDougGregor:structured-concurrencyfrom
Conversation
Is this code example missing the `try await` keywords when chopping veggies? In the previous example, inside the loop that would not produce any meaningful concurrency, line 190 is written: ```swift veggies[i] = try await veggies[i].chopped() ``` It seems like the `chopped()` method has the potential for a kitchen knife incident for each veggie. I assume this needs to be accounted for in the meaningful concurrency example too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this code example missing the
try awaitkeywords when chopping veggies? In the previous example, inside the loop that would not produce any meaningful concurrency, line 190 is written:It seems like the
chopped()method has the potential for an async kitchen knife incident for each veggie. I assume this potential also needs to be accounted for in the meaningful concurrency example too?