add proper macos titlebar support#1033
Open
aaravjhamb wants to merge 1 commit into
Open
Conversation
aaravjhamb
force-pushed
the
feat/macos-titlebar-double-click
branch
2 times, most recently
from
fd2ecda to
7019cca
Compare
Override sendEvent in MainFlutterWindow so a double-click in the top title-bar strip performs the native window action, honoring the "Double-click a window's title bar to" system preference (zoom, minimize, or do nothing). Needed because the full-size content view with a hidden title bar means the Flutter view covers the native title bar.
aaravjhamb
force-pushed
the
feat/macos-titlebar-double-click
branch
from
7019cca to
a51f853
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The window uses a full-size content view with a hidden title bar, so the Flutter view covers the entire window and AppKit's default "double-click the title bar to zoom/minimize" never reaches the native title bar.
Pull Request Description
Added a proper macos titlebar that supports macOS actions like double clicking to snap
Issue Being Fixed
Resolves the issue of titlebar not snapping to fullscreen on macOS
Screenshots / Recordings
Tested On
Checklist