fix(compose): attach all services to dokploy-network - #5164
Open
eni4sure wants to merge 2 commits into
Open
Conversation
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
The PR ensures that every service in a non-isolated Docker Compose deployment joins
dokploy-network.Previously, the network attachment happened inside the enabled-domain loop and as a result, only services with a domain attached joined
dokploy-network, while workers, databases, caches, and other supporting services are disconnected.The default attachment now runs across all Compose services. Isolated deployments remain unchanged, and an explicit per-service
Detach dokploy-networkconfiguration still takes precedence.Regression tests cover both the multi-service default behavior and explicit service detachment.
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
N/A
Screenshots (if applicable)
Greptile Summary
This PR makes non-isolated Compose deployments attach every eligible service to the shared
dokploy-network, rather than only services with enabled domains.network_mode.Confidence Score: 5/5
The PR appears safe to merge.
The previously reported mutual-exclusion failure is fixed by skipping automatic network attachment for services that define
network_mode, and no blocking failure remains.Reviews (2): Last reviewed commit: "Update packages/server/src/utils/docker/..." | Re-trigger Greptile
Context used: