Skip to content

fix(compose): attach all services to dokploy-network - #5164

Open
eni4sure wants to merge 2 commits into
Dokploy:canaryfrom
eni4sure:fix/compose-dokploy-network
Open

fix(compose): attach all services to dokploy-network#5164
eni4sure wants to merge 2 commits into
Dokploy:canaryfrom
eni4sure:fix/compose-dokploy-network

Conversation

@eni4sure

@eni4sure eni4sure commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What is this PR about?

The PR ensures that every service in a non-isolated Docker Compose deployment joins dokploy-network .

Previously, the network attachment happened inside the enabled-domain loop and as a result, only services with a domain attached joined dokploy-network, while workers, databases, caches, and other supporting services are disconnected.

The default attachment now runs across all Compose services. Isolated deployments remain unchanged, and an explicit per-service Detach dokploy-network configuration still takes precedence.

Regression tests cover both the multi-service default behavior and explicit service detachment.

Checklist

Before submitting this PR, please make sure that:

  • You created a dedicated branch based on the canary branch.
  • You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Issues related (if applicable)

N/A

Screenshots (if applicable)

image

Greptile Summary

This PR makes non-isolated Compose deployments attach every eligible service to the shared dokploy-network, rather than only services with enabled domains.

  • Skips automatic attachment for services using network_mode.
  • Preserves explicit per-service detachment.
  • Adds regression coverage for multi-service attachment and detachment.

Confidence Score: 5/5

The PR appears safe to merge.

The previously reported mutual-exclusion failure is fixed by skipping automatic network attachment for services that define network_mode, and no blocking failure remains.

Reviews (2): Last reviewed commit: "Update packages/server/src/utils/docker/..." | Re-trigger Greptile

Context used:

@eni4sure
eni4sure requested a review from Siumauricio as a code owner August 22, 2026 16:04
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 22, 2026
Comment thread packages/server/src/utils/docker/domain.ts
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant