fix(traefik): skip empty service reconnect - #5160
Open
bestmaa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before
When the Compose query returned
[], the existing truthiness guard did not return. The function built an empty command and called:In the Docker regression run, both empty-deployment tests failed and showed those exact calls. In production this surfaces as
The argument 'file' cannot be emptywhile updating the Traefik environment.After
The function now returns when
composeResult.length === 0. Existing local and remote reconnect commands are unchanged when isolated deployments exist.Validation
buildtarget on Node 24.4.0: passedFixes #5145
Greptile Summary
The PR prevents Traefik reconnection from invoking local or remote command executors when no isolated Compose deployments exist.
Confidence Score: 5/5
The PR appears safe to merge, with the empty-result failure corrected while preserving populated local and remote reconnect behavior.
The relational query returns an array, and the new explicit length check prevents empty command execution without changing command generation or executor selection when isolated deployments exist.
Reviews (1): Last reviewed commit: "fix(traefik): skip empty service reconne..." | Re-trigger Greptile