Skip to content

fix: restore button visibility and unzip path validation for backups#4344

Open
aayushbaluni wants to merge 1 commit intoDokploy:canaryfrom
aayushbaluni:fix/4331-backup-restore-button
Open

fix: restore button visibility and unzip path validation for backups#4344
aayushbaluni wants to merge 1 commit intoDokploy:canaryfrom
aayushbaluni:fix/4331-backup-restore-button

Conversation

@aayushbaluni
Copy link
Copy Markdown

Problem

The backup restore button disappears after certain interactions, and unzip operations can fail silently when given directory paths instead of file paths.

Change

  • Fix the restore button disabled/visibility state logic
  • Add path validation for backup restoration to reject directories
  • Surface unzip errors properly instead of swallowing them

Fixes #4331.

Made with Cursor

@aayushbaluni aayushbaluni requested a review from Siumauricio as a code owner May 2, 2026 04:01
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels May 2, 2026
@finnvyrn
Copy link
Copy Markdown

finnvyrn commented May 5, 2026

Sorry, I made a mistake. Please see #4331 (comment). If you can see the Restore button after horizontally scrolling the bar, maybe this pull request is no longer needed.

@aayushbaluni
Copy link
Copy Markdown
Author

Thanks for the follow-up @finnvyrn! I see that the Restore button is indeed accessible via horizontal scroll. However, this PR still improves UX by ensuring the button remains visible without requiring horizontal scrolling when filenames are long — which aligns with your suggestion to "always show the Restore button." Happy to close if the maintainers feel it's not needed though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backup restoration doesn't work: "Restore" button disappears after selecting a zip file

2 participants