fix: restore button visibility and unzip path validation for backups#4344
Open
aayushbaluni wants to merge 1 commit intoDokploy:canaryfrom
Open
fix: restore button visibility and unzip path validation for backups#4344aayushbaluni wants to merge 1 commit intoDokploy:canaryfrom
aayushbaluni wants to merge 1 commit intoDokploy:canaryfrom
Conversation
|
Sorry, I made a mistake. Please see #4331 (comment). If you can see the Restore button after horizontally scrolling the bar, maybe this pull request is no longer needed. |
Author
|
Thanks for the follow-up @finnvyrn! I see that the Restore button is indeed accessible via horizontal scroll. However, this PR still improves UX by ensuring the button remains visible without requiring horizontal scrolling when filenames are long — which aligns with your suggestion to "always show the Restore button." Happy to close if the maintainers feel it's not needed though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The backup restore button disappears after certain interactions, and unzip operations can fail silently when given directory paths instead of file paths.
Change
Fixes #4331.
Made with Cursor