fix: remove leftover debug console.log statements#4338
Open
BradPerbs wants to merge 1 commit intoDokploy:canaryfrom
Open
fix: remove leftover debug console.log statements#4338BradPerbs wants to merge 1 commit intoDokploy:canaryfrom
BradPerbs wants to merge 1 commit intoDokploy:canaryfrom
Conversation
Three stray debug console.log calls had been left in production code paths: - restore-backup.tsx: logged the full form payload on every backup restore submission. - add-database.tsx: logged the libsql `enableNamespaces` field value from inside a `render` callback, firing on every re-render of the parent form. - project.ts (duplicateProject mutation): logged the freshly-created target project/environment row on the server on every duplicate. No behaviour change; strictly removes log noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three stray debug
console.logcalls were left behind in production code paths. This PR removes them.Removals:
apps/dokploy/components/dashboard/database/backups/restore-backup.tsxLogged the full form-submission payload (
{ data }) on every backup restore submit.apps/dokploy/components/dashboard/project/add-database.tsxLogged
field.valuefor the libsqlenableNamespacesfield from inside therendercallback, so it fired on every re-render of the parent form (every keystroke that re-rendered).apps/dokploy/server/api/routers/project.tsServer-side log of the freshly-created
targetProjectrow in theduplicateProjectmutation, leaking a DB object into production logs on every duplicate.Why these and not others: I deliberately kept
console.log/console.errorcalls that look intentional (server boot logs inserver.ts, error paths incatchblocks, BullMQ queue lifecycle messages). Only the three above had no surrounding intentional-logging context and were clearly leftover from local debugging.Risk: zero behaviour change — strictly removes log noise. No tests touch these specific lines.