chore: update @better-auth/sso and better-auth to version 1.5.0-beta.…#3783
Open
Siumauricio wants to merge 27 commits intocanaryfrom
Open
chore: update @better-auth/sso and better-auth to version 1.5.0-beta.…#3783Siumauricio wants to merge 27 commits intocanaryfrom
Siumauricio wants to merge 27 commits intocanaryfrom
Conversation
…16; rename session_temp table to session and adjust related constraints; add new SQL migration for session table; implement getTrustedProviders function for dynamic provider retrieval
| member?.user.enableEnterpriseFeatures || false; | ||
| session.user.isValidEnterpriseLicense = | ||
| member?.user.isValidEnterpriseLicense || false; | ||
| session.session.activeOrganizationId = member?.organization.id || ""; |
Contributor
There was a problem hiding this comment.
setting activeOrganizationId after retrieving the member creates inconsistency. The query searches for a member using session.session.activeOrganizationId (if present), but then unconditionally overwrites it with member?.organization.id || "". If member is null, this sets activeOrganizationId to an empty string, which could cause issues on subsequent requests.
…uding hono, ai-sdk packages, and react-hook-form
…ema resolver; update dependencies in pnpm-lock.yaml
…ing zod to version 4.3.6, @dokploy/trpc-openapi to version 0.0.13, and @trpc packages to version 11.10.0; refactor loading state handling in application components
…react to version 5.31.2; refactor OpenAPI document handling in swagger.tsx and settings.ts for improved compatibility and clarity
…lock.yaml; refactor schema definitions for improved clarity and consistency across various database schemas
…ma for improved consistency and clarity
…o use undefined instead of null for improved consistency; enhance error handling in AI component
…e consistency and clarity across create, update, and remove operations
…moving transformer to the main return object for improved clarity
…proved consistency across API routes and schemas
… in package.json files and update pnpm-workspace.yaml for shared dependency management
…iles and remove catalog reference for improved dependency management
…ging instructions
…ase type for improved clarity and consistency
… export the connection for consistent usage across the application
…prevent redeclaration issues in monorepos and improve connection management in development and production environments
… module resolution in the schedules app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…16; rename session_temp table to session and adjust related constraints; add new SQL migration for session table; implement getTrustedProviders function for dynamic provider retrieval
What is this PR about?
Please describe in a short paragraph what this PR is about.
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
Screenshots (if applicable)
Greptile Summary
This PR updates
@better-auth/ssoandbetter-authfrom version 1.4.18 to 1.5.0-beta.16, and includes several related changes to align with the new version:session_temptable tosessionvia database migrationtrustedProvidersfrom static environment variable to dynamic database lookup via newgetTrustedProviders()functionvalidateRequestlogic to conditionally filter byactiveOrganizationIdand fall back to default organization when not setKey changes:
activeOrganizationIdby selecting user's default/newest organizationConfidence Score: 3/5
validateRequestlogic has a potential issue whereactiveOrganizationIdis unconditionally overwritten even when member is null, which could cause session state inconsistenciespackages/server/src/lib/auth.ts- the session validation logic change needs verificationLast reviewed commit: 6cc646c