fix: swap middleware order so stripPrefix runs before addPrefix#3759
Open
mixelburg wants to merge 1 commit intoDokploy:canaryfrom
Open
fix: swap middleware order so stripPrefix runs before addPrefix#3759mixelburg wants to merge 1 commit intoDokploy:canaryfrom
mixelburg wants to merge 1 commit intoDokploy:canaryfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3709
When both Strip Path and Internal Path are configured on a domain, the
addPrefixmiddleware was being pushed onto the middlewares array beforestripPrefix. Since Traefik executes middlewares in array order, this caused the prefix to be added to the full unstripped path.Swapped the two blocks so
stripPrefixruns first, matching the documented behavior.Greptile Summary
Swapped middleware order in
packages/server/src/utils/traefik/domain.ts:140-149sostripPrefixexecutes beforeaddPrefix. When both Strip Path and Internal Path are configured, Traefik processes middlewares in array order, so the strip operation must happen first to remove the external path before the internal path is added.Confidence Score: 5/5
Last reviewed commit: 05c80f4
(4/5) You can add custom instructions or style guidelines for the agent here!