Detect inline style attributes#25
Merged
cpeel merged 1 commit intoDistributedProofreaders:masterfrom Apr 5, 2026
Merged
Conversation
cpeel
approved these changes
Apr 5, 2026
pphtml.py
Outdated
Comment on lines
+1129
to
+1130
| if r[0].startswith("[pass]"): | ||
| r[0] = "[info] inline styles found" |
Member
There was a problem hiding this comment.
This clearly works but feels weird. It would make more sense to me if:
r = []
# do the for loop that appends to r if the regex matches
r.insert(0, "[info] inline styles found" if r else "[pass] no inline styles found")
Member
Author
There was a problem hiding this comment.
Reasonable; I made that change. Seems to work the same as before.
Find and report style attributes found on HTML tags (if any). If none are detected, consider it a [pass]; if any are found, it's only [info]. This ports a check from the legacy pptools site.
tangledhelix
force-pushed
the
inline-styles
branch
from
c1f8d7a to
8e11857
Compare
windymilla
approved these changes
Apr 5, 2026
cpeel
approved these changes
Apr 5, 2026
srjfoo
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Find and report style attributes found on HTML tags (if any). If none are detected, consider it a [pass]; if any are found, it's only [info].
This ports a check from the legacy pptools site.
Example outputs:
No style attributes found:
Style attributes found: