Add Switch File button to ppcomp dialog#1726
Merged
windymilla merged 1 commit intoDistributedProofreaders:masterfrom Feb 14, 2026
Merged
Add Switch File button to ppcomp dialog#1726windymilla merged 1 commit intoDistributedProofreaders:masterfrom
Switch File button to ppcomp dialog#1726windymilla merged 1 commit intoDistributedProofreaders:masterfrom
Conversation
1. Saves the messages currently visible in the ppcomp dialog. Does not save messages that have been hidden. 2. Switches which file is loaded: HTML or text 3. Re-creates the dialog 4. Populates the dialog with the saved messages, but swapping display of text and HTML line numbers 5. Re-selects the same message that was selected before Fixes DistributedProofreaders#1725
srjfoo
approved these changes
Feb 14, 2026
rtonsing
approved these changes
Feb 14, 2026
Collaborator
|
Ideally we wouldn't need to close and re-open the ppcomp window each time we switch files, but since it's saving the content and re-opening, it achieves the goal of having the ability to switch files and still have the content available. I tried several different file sets and didn't experience any issues. I especially like that the highlight colors were added to the color palette in the settings because I've always used ppcomp with the text file first and HTML second, so I'm used to the HTML being green and the text being purple. But since I can switch the colors, I don't have to retrain my brain to the color meanings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1725