Consolidate common PPcomp diff#1714
Merged
windymilla merged 2 commits intoDistributedProofreaders:masterfrom Feb 5, 2026
Merged
Consolidate common PPcomp diff#1714windymilla merged 2 commits intoDistributedProofreaders:masterfrom
windymilla merged 2 commits intoDistributedProofreaders:masterfrom
Conversation
Where a line is italic, frequently get solitary underscore in diffs, then the closing underscore on the end of the next line. Particularly happens in poetry. Consolidate those two diffs into one. Fixes DistributedProofreaders#1711
srjfoo
approved these changes
Feb 4, 2026
Increment line number of underscore diff from italic verse
srjfoo
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where a line is italic, frequently get solitary underscore in diffs, then the closing underscore on the end of the next line. Particularly happens in poetry. Consolidate those two diffs into one.
Fixes #1711
Note that the start of a poetry verse (which likely has an underscore in the text version) will still have the underscore on a line on its own, but lines in the middle of a verse will generally be consolidated by this commit.
Test file