Remove JS code to open in new window#1559
Merged
cpeel merged 1 commit intoDistributedProofreaders:masterfrom Dec 26, 2025
Merged
Remove JS code to open in new window#1559cpeel merged 1 commit intoDistributedProofreaders:masterfrom
cpeel merged 1 commit intoDistributedProofreaders:masterfrom
Conversation
Having links open in a new window without some visual indication is very unexpected and pop-up blockers often block them. The default value for i_newwin was changed to 0 in 2020, time to remove this entirely.
chrismiceli
approved these changes
Dec 26, 2025
srjfoo
approved these changes
Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having links open in a new window without some visual indication is very unexpected and pop-up blockers often block them. Moreover, opening a new window of a specific size and controlling the status bar / toolbar is an idea of 20 years ago, not how users use the web today. Users can open a link in a new tab, or window, via several common methods. The default value for
i_newwinwas changed to 0 in 2020, time to remove this entirely.This is also a stepping stone towards the new PI where we won't have these server-side user proofreading profiles.
Fixes #405.
Sandbox: https://www.pgdp.org/~cpeel/c.branch/remove-new-window-futzing/