Add missing JS files to eslint#1558
Add missing JS files to eslint#1558cpeel wants to merge 1 commit intoDistributedProofreaders:masterfrom
Conversation
| "scripts/api.js", | ||
| "scripts/character_test.js", | ||
| "scripts/control_bar.js", | ||
| "scripts/dropdown.js", |
There was a problem hiding this comment.
I can't remember why we didn't do *.js, because we should be able to, with appropriate excludes if necessary.
There was a problem hiding this comment.
You didn't, this is me being dumb. We don't need this PR.
If I look closely this is the modules section which should only have the modules in it -- not the scripts which are covered under the wildcard above. And that's why the other changes were needed -- because they are being checked as modules even though they weren't.
Sorry for the kerfuffle and thanks for calling this out Chris.
| /* exported barLineGraph, stackedAreaGraph, pieGraph */ | ||
|
|
||
| // eslint-disable-next-line no-unused-vars | ||
| const { barLineGraph, stackedAreaGraph, pieGraph } = (function () { |
There was a problem hiding this comment.
interesting the exported from above doesn't resolve this.
| @@ -1,4 +1,4 @@ | |||
| /*global */ | |||
| /* eslint-disable no-unused-vars */ | |||
There was a problem hiding this comment.
hmm, I wonder if more exported are needed? Since we switched to modules though, we should rely on exports or window property assignments to resolve this?
3 participants
Not sure how we missed having all the JS files in eslint, but this sweeps the codebase to add them all.
No sandbox, the CI passing is all we need.