RS-22593: Expose Price Sensitivity Meter chart title as ChartLabels$ChartTitle#20
Closed
JustinCCYap wants to merge 1 commit into
Closed
RS-22593: Expose Price Sensitivity Meter chart title as ChartLabels$ChartTitle#20JustinCCYap wants to merge 1 commit into
JustinCCYap wants to merge 1 commit into
Conversation
…hartTitle The chart title is forwarded to Line via ... but was not exposed on the output, so consumers reading attr(x, "ChartLabels")$ChartTitle (e.g. the LLM-readable generation) could not label the chart's data. Merge the title into the ChartLabels attribute alongside the existing ChartData, without overwriting the SeriesLabels that Line already sets. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linevia...) but did not expose it on the output object, so consumers readingattr(x, "ChartLabels")$ChartTitle— notably the LLM-readable generation used by Chat to answer questions from existing outputs — could not label the chart's data.PriceSensitivityMeternow merges the title into theChartLabelsattribute asChartTitle, alongside the existingChartData, without overwriting theSeriesLabelsthatLinealready sets. The title is only exposed when non-empty.Jira: https://numbers.atlassian.net/browse/RS-22593
Test plan
test_that("Chart title exposed as ChartLabels$ChartTitle", ...)asserts the title is exposed when set and absent when empty, and thatChartDatais still attached.AI code etiquette
🤖 Generated with Claude Code