Skip to content

ENG-1584 Add draft status to ontology files#920

Open
maparent wants to merge 3 commits intomainfrom
eng-1584-add-draft-status-to-ontology-files
Open

ENG-1584 Add draft status to ontology files#920
maparent wants to merge 3 commits intomainfrom
eng-1584-add-draft-status-to-ontology-files

Conversation

@maparent
Copy link
Collaborator

@maparent maparent commented Mar 27, 2026

@linear
Copy link

linear bot commented Mar 27, 2026

@supabase
Copy link

supabase bot commented Mar 27, 2026

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@maparent maparent requested a review from joelchan March 27, 2026 02:13
devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 4 additional findings in Devin Review.

Open in Devin Review


<https://discoursegraphs.com/schema/dg_core> a owl:Ontology;
dc:date "2025-12-22" ;
dc:modified "2026-03-26" ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 dc:modified is not a valid Dublin Core Elements 1.1 property

The dc: prefix is bound to http://purl.org/dc/elements/1.1/ (line 4), which defines exactly 15 properties — modified is not one of them. Using dc:modified creates a triple with the IRI http://purl.org/dc/elements/1.1/modified, which is undefined in any standard vocabulary. Standard-aware RDF/OWL tools looking for modification dates expect dcterms:modified from http://purl.org/dc/terms/. This means the modification date won't be discoverable by any tool following standard vocabulary conventions.

Note: the same incorrect pattern pre-exists in apps/roam/src/utils/jsonld.ts:23, but this PR extends it to a published Turtle schema file.

Prompt for agents
In apps/website/public/schema/dg_core.ttl, add a new prefix declaration for Dublin Core Terms:
  @prefix dcterms: <http://purl.org/dc/terms/> .

Then on line 16, change:
  dc:modified "2026-03-26" ;
to:
  dcterms:modified "2026-03-26" ;

Also consider fixing the same issue in apps/roam/src/utils/jsonld.ts line 23 where `modified` is mapped to `dc:modified`. It should either add a `dcterms` prefix mapping to `http://purl.org/dc/terms/` and map `modified` to `dcterms:modified`, or keep the current behavior if intentional for internal consistency.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

graphite-app[bot]

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant