[ENG-1582] Node menu hotkey on text selection

[trangdoan982]

Summary

• When the node tag hotkey is pressed without text selected, the existing candidate node tag popover opens as before
• When pressed with text selected, a new inline node type picker appears showing all node types
• Selecting a node type creates a discourse node from the selected text and replaces it with a [[wiki-link]]

Closes ENG-1582

Test plan

https://www.loom.com/share/3df52ae11a884fa5adc749487066e501

• Press node tag hotkey with no selection → tag popover opens (regression)
• Select text, press hotkey → node type picker appears near cursor
• Pick a node type → new file created, selection replaced with [[formatted-name]]
• Press Escape → picker closes without changes
• Arrow keys + Enter navigate and select in the picker
• Selected text with invalid filename chars → Notice shown

🤖 Generated with Claude Code

---

[linear]

ENG-1582 Modify the node menu key so that if there's no text selection, we open the candidate node menu, but if there's selection, we open node menu in-line

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[graphite-app]

When items.length is 0, this calculation produces -1 as the new index:

Math.min(this.selectedIndex + 1, this.items.length - 1)
// When items.length = 0: Math.min(1, -1) = -1

This sets selectedIndex to -1, which is invalid. Add a guard check:

if (e.key === "ArrowDown") {
  e.preventDefault();
  e.stopPropagation();
  if (this.items.length === 0) return;
  const newIndex = Math.min(
    this.selectedIndex + 1,
    this.items.length - 1,
  );
  this.updateSelectedIndex(newIndex);
  this.scrollToSelected();
}

The same guard should be added to the ArrowUp handler.

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.