Skip to content

[ENG-1547] Add relation type editing via click on existing arrows #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trangdoan982 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[ENG-1547] Add relation type editing via click on existing arrows #909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ebe9ce
drag handle works
trangdoan982 Mar 23, 2026
75c8668
[ENG-1547] Add relation type editing via click on existing arrows
trangdoan982 Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/obsidian/src/components/canvas/TldrawViewComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@
} from "~/components/canvas/shapes/DiscourseRelationBinding";
import ToastListener from "./ToastListener";
import { RelationsOverlay } from "./overlays/RelationOverlay";
import { DragHandleOverlay } from "./overlays/DragHandleOverlay";
import { showToast } from "./utils/toastUtils";

Check warning on line 50 in apps/obsidian/src/components/canvas/TldrawViewComponent.tsx

View workflow job for this annotation

GitHub Actions / eslint (apps/obsidian)

[eslint (apps/obsidian)] apps/obsidian/src/components/canvas/TldrawViewComponent.tsx#L50 

'showToast' is defined but never used  @typescript-eslint/no-unused-vars
Raw output 
  50:10  warning  'showToast' is defined but never used  @typescript-eslint/no-unused-vars
import { WHITE_LOGO_SVG } from "~/icons";
import { CustomContextMenu } from "./CustomContextMenu";
import {
Expand Down Expand Up @@ -474,7 +476,10 @@
);
},
InFrontOfTheCanvas: () => (
<RelationsOverlay plugin={plugin} file={file} />
<>
<RelationsOverlay plugin={plugin} file={file} />
<DragHandleOverlay plugin={plugin} file={file} />
</>
),
}}
/>
Expand Down
Loading
Loading