Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
trangdoan982
force-pushed
the
eng-1108-tool-lock
branch
from
81fc1d3 to
b92b6cf
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| return ( | ||
| <div | ||
| className="roamjs-tldraw-canvas-container relative z-10 h-full w-full overflow-hidden rounded-md border border-gray-300 bg-white" | ||
| data-page-uid={pageUid} |
There was a problem hiding this comment.
we need to add this back because i keep receiving error "No canvas page UID found"
There was a problem hiding this comment.
It seems there was come confusion on what the task was requesting. Unfortunately, the ticket should have been more clear, sorry.
If a user:
- selects dg tool
- toggle lock on
- creates a node
The dg tool/node should still be the current tool
If a user:
- selects dg tool
- toggles lock off (or leaves as default)
- creates a node
The current tool should be the select tool
This follows the same behavior as all other tldraw tools.
|
@mdroidian is this the same behavior we want for ENG-1383: Stay at the relation arrow menu after creating a relation? Based on the description in this ticket I understood that once the discourse relation tool is selected, it should stay locked there without doing any extra lock tool operation. In this latest push I had discourse node and relation tools to have the same behavior, but let me know if you interpret it differently. |
trangdoan982
force-pushed
the
eng-1108-tool-lock
branch
from
0211007 to
faa17a5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mdroidian
left a comment
mdroidian
left a comment
There was a problem hiding this comment.
https://www.loom.com/share/07aab48252a744f4ad016e00e619e7e1
- cannot edit discourse nodes
- changing default tldraw lock behavior unnecessarily (unlocking on choosing select tool)
trangdoan982
force-pushed
the
eng-1108-tool-lock
branch
from
d0b007d to
7a44a8c
Compare
|
https://www.loom.com/share/878e7f7432b645ceb310c914ed200d93 Here's my updated test with the bugs you pointed out. I couldn't reproduce the unable to edit bug. Can you try again? |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mdroidian
left a comment
mdroidian
left a comment
There was a problem hiding this comment.
There are some undesired changes that I am unclear why they are included in this PR.
Also, this devin comment is worth looking into: #851 (comment)
trangdoan982
force-pushed
the
eng-1108-tool-lock
branch
from
edbaf77 to
4a8c0c9
Compare
2 participants
https://www.loom.com/share/07b5bafb3bb54450bbe9a40862f9cd4a