Skip to content

ENG-2040 Test the generic upsert route #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
maparent wants to merge 2 commits into
base: eng-2039-create-a-generic-upsert-route
Choose a base branch
from
Draft

ENG-2040 Test the generic upsert route #1238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c32717
ENG-2040: Test the generic upsert route
maparent Jul 19, 2026
a039e33
Start next server in cucumber tests
maparent Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
134 changes: 134 additions & 0 deletions packages/database/features/addGeneric.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,134 @@
Feature: Concept upsert
User story:
* As a user of the Roam plugin
* Logged in through a given space's anonymous account
* I want to be able to upsert concepts to that space

Acceptance criteria:
* The upsert should succeed

Background:
Given the database is blank
And the user user1 opens the Roam plugin in space s1

Scenario Outline: Calling the upsert steps together
When user user1 upserts this cross-app data to space s1:
"""
{
"nodeSchemas": [
{
"label": "Claim",
"authorId": "user1",
"localId": "ns1",
"createdAt": "2000/01/01",
"modifiedAt": "2001/01/02"
}
],
"relationTripleSchemas": [
{
"authorId": "user1",
"localId": "r3s1",
"label": "supports",
"complement": "supportedBy",
"sourceType": "ns1",
"destinationType": "ns1",
"createdAt": "2000/01/01",
"modifiedAt": "2001/01/02"
}
],
"nodes": [
{
"title": "Some first claim",
"authorId": "user1",
"localId": "n1",
"nodeType": "ns1",
"createdAt": "2000/01/01",
"modifiedAt": "2001/01/02",
"content": {
"direct": {
"value": "Some text"
}
}
},
{
"title": "Some second claim",
"authorId": "user1",
"localId": "n2",
"nodeType": "ns1",
"createdAt": "2000/01/03",
"modifiedAt": "2001/01/04",
"content": {
"direct": {
"value": "Some subtext",
"embedding": {
"model": "openai_text_embedding_3_small_1536",
"value": [
1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0
]
}
}
}
}
],
"relations": [
{
"name": "a supports relation",

@mdroidian mdroidian Jul 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this match CrossAppRelation?

"authorId": "user1",
"nodeType": "r3s1",
"createdAt": "2000/01/04",
"modifiedAt": "2001/01/05",
"source": "n1",
"destination": "n2"
}
]
}
"""
Then a user logged in space s1 should see 5 Concept in the database
And a user logged in space s1 should see 2 Content in the database
And a user logged in space s1 should see 1 ContentEmbedding_openai_text_embedding_3_small_1536 in the database
35 changes: 35 additions & 0 deletions packages/database/features/step-definitions/stepdefs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ import {
type Enums,
type Json,
} from "@repo/database/dbTypes";
import type { DGSupabaseClient } from "~/lib/client";
import { getVariant, config } from "@repo/database/dbDotEnv";
import { getConcepts, initNodeSchemaCache } from "@repo/database/lib/queries";
import axios from "axios";

import {
spaceAnonUserEmail,
Expand Down Expand Up @@ -268,6 +270,21 @@ const getLoggedinDatabase = async (spaceId: number) => {
return client;
};

const getApiHeader = async (supabase: DGSupabaseClient) => {
const session = await supabase.auth.getSession();
const sessionData = session.data?.session;
assert(sessionData, "Cannot find session token");
const token = btoa(JSON.stringify(sessionData));
return {
Cookie: `sb-127-auth-token=base64-${token}`,
};
};

const getApiHeaderForSpace = async (spaceId: number) => {
const supabase = await getLoggedinDatabase(spaceId);
return await getApiHeader(supabase);
};

const getLoggedinDatabaseForUsername = async (userName: string) => {
assert.notStrictEqual(userName, undefined);
const localRefs = (world.localRefs || {}) as LocalRefsType;
Expand Down Expand Up @@ -421,6 +438,24 @@ Given(
},
);

// invoke the vercel upsert function, expects json
Given(
"user {word} upserts this cross-app data to space {word}:",
async (userName: string, spaceName: string, docString: string) => {
const data = JSON.parse(docString) as Record<string, unknown>;
const localRefs = (world.localRefs || {}) as LocalRefsType;
const spaceId = localRefs[spaceName];
if (typeof spaceId !== "number") assert.fail("spaceId not a number");
const headers = await getApiHeaderForSpace(spaceId);
const response = await axios.post(
`http://localhost:3000/api/internal/space/${spaceId}`,
data,
{ headers },
);
assert.equal(response.status, 200);
},
);

Given(
"a user logged in space {word} and calling getConcepts with these parameters: {string}",
async (spaceName: string, paramsJ: string) => {
Expand Down
1 change: 1 addition & 0 deletions packages/database/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
"@repo/typescript-config": "workspace:*",
"@types/node": "catalog:",
"@vercel/sdk": "^1.19.40",
"axios": "^0.27.2",
"dotenv": "^16.6.1",
"eslint": "catalog:",
"prettier-plugin-gherkin": "^3.1.3",
Expand Down
119 changes: 80 additions & 39 deletions packages/database/scripts/serveAndTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { spawn, execSync } from "node:child_process";
import { spawn, execSync, ChildProcessByStdio } from "node:child_process";
import { join, dirname } from "path";
import type { Readable } from "node:stream";

const scriptDir = dirname(__filename);
const projectRoot = join(scriptDir, "..");
Expand All @@ -16,58 +17,96 @@ if (process.env.SUPABASE_PROJECT_ID !== "test") {
process.exit(2);
}

const serve = spawn("supabase", ["functions", "serve"], {
cwd: projectRoot,
detached: true,
stdio: ["ignore", "pipe", "inherit"],
});
process.env["SUPABASE_USE_DB"] = "local";

let resolveCallback: ((value: unknown) => void) | undefined = undefined;
let rejectCallback: ((reason: unknown) => void) | undefined = undefined;
let serveSuccess = false;
let timeoutClear: NodeJS.Timeout | undefined = undefined;
class ParallelServer {
process: ChildProcessByStdio<null, Readable, null>;
promise: Promise<boolean>;
serveSuccess = false;
resolveCallback:
| ((value: boolean | PromiseLike<boolean>) => void)
| undefined;
rejectCallback: ((reason: unknown) => void) | undefined;
timeoutClear: NodeJS.Timeout | undefined;
constructor({
cmd,
args,
readySignal,
dir,
}: {
cmd: string;
args: string[];
readySignal: string;
dir?: string;
}) {
this.process = spawn(cmd, args, {
cwd: dir || projectRoot,
detached: true,
stdio: ["ignore", "pipe", "inherit"],
});
this.promise = new Promise((rsc, rjc) => {
this.resolveCallback = rsc;
this.rejectCallback = rjc;

const servingReady = new Promise((rsc, rjc) => {
resolveCallback = rsc;
rejectCallback = rjc;
// Add timeout

@mdroidian mdroidian Jul 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

this.timeoutClear = setTimeout(() => {
rjc(new Error("Timeout waiting for functions to serve"));
}, 30000); // 30 second timeout

@mdroidian mdroidian Jul 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

});
this.process.stdout.on("data", (data: Buffer) => {
const output = data.toString();
console.log(`stdout: ${output}`);
if (output.includes(readySignal)) {
console.log("Found serving functions");
this.serveSuccess = true;
clearTimeout(this.timeoutClear);
if (this.resolveCallback === undefined)
throw new Error("did not get callback");
this.resolveCallback(true);
}
});
this.process.on("close", () => {
if (!this.serveSuccess && this.rejectCallback)
this.rejectCallback(new Error("serve closed without being ready"));
});
this.process.on("error", (err) => {
if (this.rejectCallback) this.rejectCallback(err);
});
}
}

// Add timeout
timeoutClear = setTimeout(() => {
rjc(new Error("Timeout waiting for functions to serve"));
}, 30000); // 30 second timeout
const supabaseServer = new ParallelServer({
cmd: "supabase",
args: ["functions", "serve"],
readySignal: "Serving functions ",
});

serve.stdout.on("data", (data: Buffer) => {
const output = data.toString();
console.log(`stdout: ${output}`);
if (output.includes("Serving functions ")) {
console.log("Found serving functions");
serveSuccess = true;
clearTimeout(timeoutClear);
if (resolveCallback === undefined) throw new Error("did not get callback");
resolveCallback(null);
}
});
serve.on("close", () => {
if (!serveSuccess && rejectCallback)
rejectCallback(new Error("serve closed without being ready"));
});
serve.on("error", (err) => {
if (rejectCallback) rejectCallback(err);
const nextServer = new ParallelServer({
cmd: "npm",
args: ["run", "dev"],
readySignal: "Ready in ",
dir: join(scriptDir, "../../../apps/website"),
});

const doTest = async () => {
try {
await servingReady;
await Promise.all([supabaseServer.promise, nextServer.promise]);
execSync("cucumber-js", {
cwd: projectRoot,
stdio: "inherit",
});
// will throw on failure
} finally {
if (serve.pid)
if (supabaseServer.process.pid)
try {
process.kill(-supabaseServer.process.pid);
} catch (e) {
console.error("Could not kill the process");
// maybe it just ended on its own.
}
if (nextServer.process.pid)

@mdroidian mdroidian Jul 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows process.kill(-pid) returned ESRCH and left the detached child alive, leaking port 3000.

try {
process.kill(-serve.pid);
process.kill(-nextServer.process.pid);
} catch (e) {
console.error("Could not kill the process");
// maybe it just ended on its own.
Expand All @@ -78,10 +117,12 @@ const doTest = async () => {
doTest()
.then(() => {
console.log("success");
clearTimeout(timeoutClear);
clearTimeout(supabaseServer.timeoutClear);
clearTimeout(nextServer.timeoutClear);
})
.catch((err) => {
console.error(err);
clearTimeout(timeoutClear);
clearTimeout(supabaseServer.timeoutClear);
clearTimeout(nextServer.timeoutClear);
process.exit(1);
});
Loading
Loading