ENG-1865 Publish Roam stored relations for shared nodes#1221
Draft
maparent wants to merge 1 commit into
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 11, 2026 13:26
df8bd66 to
7e9a33d
Compare
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 13, 2026 04:01
7e9a33d to
e15e0eb
Compare
maparent
marked this pull request as ready for review
July 13, 2026 14:44
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 13, 2026 14:53
e15e0eb to
9e93709
Compare
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 13, 2026 15:04
9e93709 to
123104f
Compare
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 13, 2026 15:29
123104f to
ae3123f
Compare
maparent
commented
Jul 13, 2026
| Omit< | ||
| Database["public"]["CompositeTypes"]["document_local_input"], | ||
| "author_inline" | ||
| "author_inline" | "contents" |
Collaborator
Author
There was a problem hiding this comment.
"content" is of type unknown, so we get typescript errors when using the LocalDocumentDataInput explicitly (even though indirectly through LocalConceptDataInput, LocalContentDataInput.)
It is not used yet, so just removing from input type for now.
I guess this did not arise earlier because we were building objects, not using the type explicitly.
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 13, 2026 15:51
ae3123f to
f71e309
Compare
maparent
marked this pull request as draft
July 13, 2026 19:51
maparent
force-pushed
the
eng-2017-add-converter-for-crossapp-schemas-to-localconceptdatainput
branch
from
July 15, 2026 18:49
c2ee00a to
1127f9a
Compare
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 15, 2026 19:06
f71e309 to
a96cd20
Compare
maparent
changed the base branch from
eng-2017-add-converter-for-crossapp-schemas-to-localconceptdatainput
to
eng-2018-add-converter-for-crossapprelation-schema-to
July 15, 2026 19:07
maparent
marked this pull request as ready for review
July 15, 2026 19:08
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 15, 2026 19:14
a96cd20 to
af01ede
Compare
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 15, 2026 19:55
af01ede to
abacebf
Compare
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 15, 2026 20:33
0bb9a97 to
3d229a1
Compare
maparent
force-pushed
the
eng-2018-add-converter-for-crossapprelation-schema-to
branch
from
July 17, 2026 12:43
812992f to
4b2715d
Compare
Base automatically changed from
eng-2018-add-converter-for-crossapprelation-schema-to
to
main
July 17, 2026 12:43
Contributor
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 17, 2026 12:45
3d229a1 to
fc0d5ae
Compare
Member
|
My understanding from the last meeting is that this PR is will be refactored. I'll move it to draft for now to reflect the status. |
mdroidian
marked this pull request as draft
July 19, 2026 20:39
mdroidian
removed their request for review
July 19, 2026 20:39
Member
|
MAP would like to base this on the upsert route ENG-2039 |
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 23, 2026 01:41
fc0d5ae to
67a8985
Compare
maparent
changed the base branch from
main
to
eng-2049-refactor-publishnodestogroup-to-use-the-crossappnodeschema
July 23, 2026 01:42
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 23, 2026 16:05
67a8985 to
7847d4c
Compare
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 23, 2026 18:53
7847d4c to
a9b80ec
Compare
maparent
force-pushed
the
eng-2049-refactor-publishnodestogroup-to-use-the-crossappnodeschema
branch
3 times, most recently
from
July 23, 2026 21:01
51ca3bc to
dc87ee0
Compare
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 23, 2026 21:52
a9b80ec to
fdd0a3d
Compare
maparent
force-pushed
the
eng-1865-publish-roam-stored-relations-for-shared-nodes
branch
from
July 23, 2026 22:03
fdd0a3d to
17a85f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/discourse-graphs/issue/ENG-1865/publish-roam-stored-relations-for-shared-nodes
Waiting for eng-1856 to work with relations to imported nodes; but functional otherwise.
One thing I expect to discuss: I put everything in one file, and it would be worth distributing code in various utility functions, and maybe breaking up the PR. We should discuss how to break it up, but I wanted to start from end-to-end functionality.
https://www.loom.com/share/74b4c5b9e750404e8ea1f59ace042492