ENG-1575 Hide left sidebar settings tabs when feature flag is off#1084
Open
sid597 wants to merge 3 commits into
Open
ENG-1575 Hide left sidebar settings tabs when feature flag is off#1084sid597 wants to merge 3 commits into
sid597 wants to merge 3 commits into
Conversation
Hide the Personal and Global "Left sidebar" tabs in the Settings dialog when the "Enable left sidebar" feature flag is disabled, using the same hidden prop pattern as the Admin tab.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Subscribe to the leftSidebarFlag setting change so the Left sidebar tabs hide/show immediately when the flag is toggled in the open settings dialog, matching the live sidebar mount/unmount in index.ts, instead of waiting for a tab switch or refresh.
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af4196bd1e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
When the flag is off, derive the displayed tab so a left-sidebar tab that ends up selected (e.g. via a deep link from the command palette) falls back to the Home tab instead of being rendered as a hidden selection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/fcc777a82622421a8f8b3d11a0ddd084