Skip to content

ENG-1748: Add shared template import panel for node types#1076

Open
trangdoan982 wants to merge 2 commits into
mainfrom
eng-1748-enable-users-to-import-templates-for-shared-node-types
Open

ENG-1748: Add shared template import panel for node types#1076
trangdoan982 wants to merge 2 commits into
mainfrom
eng-1748-enable-users-to-import-templates-for-shared-node-types

Conversation

@trangdoan982
Copy link
Copy Markdown
Member

@trangdoan982 trangdoan982 commented May 24, 2026

https://www.loom.com/share/6343ad0f31bf4e37a3cb62c1c53da546

Summary

  • add a dedicated "Import template from groups" flow in Node Type settings with candidate fetching, selection, and one-click import into the local templates folder
  • Template Import UI is a split-panel modal with template list metadata (name, optional author, source space, publish time) and live markdown preview
  • prevent duplicate imports by naming imported templates as <template> (from <space>) and filtering already imported candidates from the panel

Test plan

  • Open Obsidian settings > Node Types > edit a node type > Template dropdown > Import template from groups
  • Confirm split layout: left candidate list + right markdown preview, with independent vertical scrolling
  • Import a template and verify local template name format is <template> (from <space>).md
  • Re-open import panel and verify the imported candidate no longer appears
  • Click "Import & use" and verify the selected node type template field is updated to the imported file

Made with Cursor

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 24, 2026

ENG-1748

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented May 24, 2026

PR size/scope check

This PR is over our review-size guideline.

  • Recommended: ~200 lines changed
  • Acceptable limit: up to 400 lines when well-scoped/self-contained
  • Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

  • What single problem this PR solves
  • Why the files/changes are coupled

@supabase
Copy link
Copy Markdown

supabase Bot commented May 24, 2026

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

Remove quoted JSX text around node type name in the empty-state message so lint-changed-files passes without changing behavior.

Co-authored-by: Cursor <cursoragent@cursor.com>
@trangdoan982 trangdoan982 requested a review from maparent May 24, 2026 18:34
@trangdoan982 trangdoan982 changed the title ENG-1748: add shared template import panel for node types ENG-1748: Add shared template import panel for node types May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant