ENG-1774: Roam performance diagnostics

apps/roam/src/components/DiscourseContextOverlay.tsx

@@ -37,8 +37,12 @@ const getOverlayInfo = async (
   ignoreCache?: boolean,
 ): Promise<DiscourseData> => {
   try {
-    const relations = getDiscourseRelations();
-    const nodes = getDiscourseNodes(relations);
+    const trace = {
+      source: "DiscourseContextOverlay:getOverlayInfo",
+      content: tag,
+    };
+    const relations = getDiscourseRelations(undefined, trace);
+    const nodes = getDiscourseNodes(relations, undefined, trace);
 
     const [results, refs] = await Promise.all([
       getDiscourseContextResults({

apps/roam/src/components/DiscourseNodeMenu.tsx

@@ -27,9 +27,13 @@
 import { OnloadArgs } from "roamjs-components/types";
 import { formatHexColor } from "./settings/DiscourseNodeCanvasSettings";
 import posthog from "posthog-js";
-import { setPersonalSetting } from "~/components/settings/utils/accessors";
+import {
+  setPersonalSetting,
+  type SettingsSnapshot,
+} from "~/components/settings/utils/accessors";
 import { PERSONAL_KEYS } from "~/components/settings/utils/settingKeys";
 import type { PersonalSettings } from "~/components/settings/utils/zodSchema";
+import type { PerformanceTraceContext } from "~/utils/performanceLogger";
 
 type Props = {
   textarea?: HTMLTextAreaElement;
@@ -38,6 +42,24 @@
   trigger?: JSX.Element;
   isShift?: boolean;
   menuMaxHeight?: number;
+  trace?: PerformanceTraceContext;
+  settingsSnapshot?: SettingsSnapshot;
+  getSettingsSnapshot?: (trace?: PerformanceTraceContext) => SettingsSnapshot;
+};
+
+const compactTraceContent = (content?: string): string | undefined => {
+  const compacted = content?.replace(/\s+/g, " ").trim();
+  return compacted ? compacted.slice(0, 120) : undefined;
+};
+
+const getNodeMenuTraceContent = ({
+  trace,
+  textarea,
+  blockUid,
+}: Pick<Props, "trace" | "textarea" | "blockUid">): string | undefined => {
+  if (trace?.content) return compactTraceContent(trace.content);
+  if (blockUid) return `blockUid:${blockUid}`;
+  return compactTraceContent(textarea?.value);
 };
 
 const NodeMenu = ({
@@ -48,17 +70,34 @@
   trigger,
   isShift,
   menuMaxHeight,
+  trace,
+  settingsSnapshot,
+  getSettingsSnapshot,
 }: { onClose: () => void } & Props) => {
   const isInitialTextSelected =
     !!textarea && textarea.selectionStart !== textarea.selectionEnd;
 
   const [showNodeTypes, setShowNodeTypes] = useState(
     isInitialTextSelected || (isShift ?? false),
   );
-  const userDiscourseNodes = useMemo(
-    () => getDiscourseNodes().filter((n) => n.backedBy === "user"),
-    [],
-  );
+  const userDiscourseNodes = useMemo(() => {
+    const traceContext = {
+      source: trace?.source ?? "component:DiscourseNodeMenu:userDiscourseNodes",
+      content: getNodeMenuTraceContent({ trace, textarea, blockUid }),
+    };
+    return getDiscourseNodes(
+      undefined,
+      settingsSnapshot ?? getSettingsSnapshot?.(traceContext),
+      traceContext,
+    ).filter((n) => n.backedBy === "user");
+  }, [
+    blockUid,
+    getSettingsSnapshot,
+    settingsSnapshot,
+    textarea,
+    trace?.content,
+    trace?.source,
+  ]);
   const discourseNodes = userDiscourseNodes.filter(
     (n) => showNodeTypes || n.tag,
   );
@@ -359,10 +398,12 @@
   textarea,
   extensionAPI,
   onClose,
+  settingsSnapshot,
 }: {
   textarea: HTMLTextAreaElement;
   extensionAPI: OnloadArgs["extensionAPI"];
   onClose: () => void;
+  settingsSnapshot?: SettingsSnapshot;
 }) => {
   const trigger = (
     <Button
@@ -403,6 +444,7 @@
       onClose={onClose}
       isShift
       menuMaxHeight={menuMaxHeight}
+      settingsSnapshot={settingsSnapshot}
     />
   );
 };

apps/roam/src/components/SuggestionsBody.tsx

@@ -51,7 +51,10 @@ const getOverlayInfo = async (
   try {
     if (cache[tag]) return cache[tag];
 
-    const nodes = getDiscourseNodes(relations);
+    const nodes = getDiscourseNodes(relations, undefined, {
+      source: "SuggestionsBody:getOverlayInfo",
+      content: tag,
+    });
 
     const [results, refs] = await Promise.all([
       getDiscourseContextResults({

apps/roam/src/components/settings/DiscourseNodeConfigPanel.tsx

@@ -22,6 +22,7 @@ import setBlockProps from "~/utils/setBlockProps";
 import { DiscourseNodeSchema } from "./utils/zodSchema";
 import { getGlobalSettings, setGlobalSetting } from "./utils/accessors";
 import { GLOBAL_KEYS } from "./utils/settingKeys";
+import { invalidateDiscourseNodeTypeCaches } from "~/utils/discourseNodeTypeCache";
 
 type DiscourseNodeConfigPanelProps = React.ComponentProps<
   CustomField["options"]["component"]
@@ -60,6 +61,7 @@ const DiscourseNodeConfigPanel: React.FC<DiscourseNodeConfigPanelProps> = ({
     await window.roamAlphaAPI.deletePage({
       page: { uid },
     });
+    invalidateDiscourseNodeTypeCaches();
     setNodes((prevNodes) => prevNodes.filter((nn) => nn.type !== uid));
     refreshConfigTree();
     setDeleteConfirmation(null);
@@ -117,6 +119,7 @@ const DiscourseNodeConfigPanel: React.FC<DiscourseNodeConfigPanelProps> = ({
                   format,
                 }),
               );
+              invalidateDiscourseNodeTypeCaches();
               setNodes([
                 ...nodes,
                 {